standardize use of arrow functions, scoped vars and for loops where possible, content.js#41
Closed
yoroshikun wants to merge 1 commit intoalyssaxuu:masterfrom
Closed
Conversation
…ossible, content.js
|
I was thinking about adding some tests to the code base, this would potentially help such refactors. I can give a try on the test setup, what do you think @alyssaxuu ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE WITHOUT CHECKING IF ALL FUNCTIONS WORK PLEASE
It is important to test this commit as there is some changes that might break things.
This commit only affects the content.js, I have done the following
== to === as its safer to do a non loose equal, and we know we don't need loose