fix: open omni automatically in "chrome://" pages#64
Closed
dubisdev wants to merge 1 commit intoalyssaxuu:masterfrom
Closed
fix: open omni automatically in "chrome://" pages#64dubisdev wants to merge 1 commit intoalyssaxuu:masterfrom
dubisdev wants to merge 1 commit intoalyssaxuu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hii!
I have seen that omni was opening a new tab when the current one was "chrome://" or "chrome.google.com", but that the shortcut needed to be re-executed to open omni.
With this fix omni opens automatically when the new tab finishes loading.
I have also seen that the "original" tab (by this I mean the one with the URL "chrome://") is closed when omni tab is opened. I don't know if that should be how it works since it is possible that the user does not want to close it but simply access omni. A possible solution could be to create the new tab and switch focus to it, without actually closing the original one.
Tell me what you think and if you agree I can take care of it :)
Thanks again for this great extension ✌️