Skip to content

Conversation

amit2rrr
Copy link
Collaborator

No description provided.

@amit1rrr amit1rrr changed the title MAINT: remove pinned versions from requirements.txt Linear Regression on Pandas DataFrame using Sci-kit Learn Dec 5, 2018
@amit1rrr
Copy link
Owner

Testing conversation comment.

pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy
Copy link
Owner

@amit1rrr amit1rrr Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment.
You can add the next version

 numpy==1.11.2

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R1 - Let me see.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R2 - It's done.

pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy
Copy link
Owner

@amit1rrr amit1rrr Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test comment - 2

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review has 2 comments in it.

requirements.txt Outdated
matplotlib==1.5.1
seaborn==0.7.0
numpy
pandas
Copy link
Owner

@amit1rrr amit1rrr Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's start a review.

requirements.txt Outdated
matplotlib==1.5.1
seaborn==0.7.0
numpy
pandas
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment as part of review

@amit1rrr
Copy link
Owner

This is a plain conversation comment.

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b

Reply via ReviewNB

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy
Copy link
Owner

@amit1rrr amit1rrr Dec 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more information here, and fix this typo. Post from ReviewNB

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more information here, and fix this typo. Post from ReviewNB

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more information here, and fix this typo. Post from ReviewNB

@amit1rrr
Copy link
Owner

amit1rrr commented Jan 2, 2019

T1 - HTML in comment ReviewNB

pillow==3.4.2
matplotlib==1.5.1
seaborn==0.7.0
numpy
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2 - HTML in comment ReviewNB

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

@@ -1,11 +1,11 @@
numpy==1.11.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T3-Please add more information here, and fix this typo. Post from ReviewNB

Copy link
Owner

@amit1rrr amit1rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close to perfect! Please address the suggested inline change.

@amit1rrr
Copy link
Owner

amit1rrr commented Jan 2, 2019

Testing conversation comment.

Quoting conversation comment.

pandas==0.18.1
scipy==0.17.1
scikit-learn==0.17.1
scikit-image==0.12.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T21-pre

Copy link
Owner

@amit1rrr amit1rrr Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants