Fix test_amp_get_schemaorg_metadata and test_wrap_widget_callbacks in Gutenberg v10.8 and WP 5.8
#6366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Contributor
|
Plugin builds for 8b58a9b are ready 🛎️!
|
westonruter
changed the title
test_amp_get_schemaorg_metadata and test_wrap_widget_callbacks in Gutenberg v10.8 and WP 5.8
westonruter
force-pushed
the
fix/test_amp_get_schemaorg_metadata
branch
from
34b794f to
8b58a9b
Compare
westonruter
added a commit
that referenced
this pull request
Jun 10, 2021
… Gutenberg v10.8 and WP 5.8 (#6366)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes tests which were broken with Gutenberg v10.8.0 (and WP Core 5.8-beta1) due to WordPress/gutenberg#32370 and WordPress/wordpress-develop#1275, accounting for Custom Logo now being stored in an option in addition to a theme mod.
Also fixes
test_wrap_widget_callbacksafter changes to default widgets registered. See WordPress/wordpress-develop@8add05f in https://core.trac.wordpress.org/ticket/53324.Checklist