-
Notifications
You must be signed in to change notification settings - Fork 382
Update Composer dependencies #6446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Plugin builds for 51036ad are ready 🛎️!
|
|
Checking what's causing the PHP tests to fail... |
| "cweagans/composer-patches": "1.7.1", | ||
| "cweagans/composer-patches": "~1.0", | ||
| "fasterimage/fasterimage": "1.5.0", | ||
| "sabberworm/php-css-parser": "dev-master#bfdd976" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like composer is locking the requirements of dev-master first, then checking out to bfdd976, causing a psr-4 namespace mismatch ("Sabberworm\\CSS\\": "src/" instead of "Sabberworm\\CSS\\": "lib/Sabberworm/CSS/") and thus not being able to autoload the library correctly.
87f5121 to
1c90850
Compare
|
Tiktok embed test was failing earlier but all seems good now 😄. |
| "require": { | ||
| "php": ">=5.3.2" | ||
| }, | ||
| "require-dev": { | ||
| "codacy/coverage": "^1.4", | ||
| "phpunit/phpunit": "^4.8.36" | ||
| }, | ||
| "phpunit/phpunit": "~4.8" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've manually reverted the psr-4 path to lib/Sabberworm/CSS/ in 1c90850. This seems like a Composer bug so I'll report it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Turns out the behavior is as intended, as explained in composer/composer#9990 (comment). I'm not sure how to resolve this then since installing the dependency from the master branch is essentially broken now. Maybe we could fork it in the interim until a new release is made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fork it in order to create a release tag to reference?
I hope that a new release of PHP-CSS-Parser will be made soon with all of the improvements being made recently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a Composer plugin as a method of patching the composer.lock file as well, but I'm not sure if we need to employ that as yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😎 You're a composer whisperer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opened a PR to add it: #6464.
Summary
Updates:
cweagans/composer-patchesto~1.0(>=1.0.0 <2.0.0) (as requested by @swissspidy in Bump cweagans/composer-patches from 1.7.0 to 1.7.1 #6363 (comment))roave/security-advisoriestodev-latestinstead ofdev-masteras recommended by the maintainerEmulated PHP version (
config.platform.php) to v5.6.20 to allowsabberworm/php-css-parserto be installed, otherwise when attempting install it would produce the error:Update: Turns out this is because the composer config of the master branch is being locked and not the config in the
bfdd976commit. I think it might be a composer bug so I'll file a report.Checklist