Skip to content

Conversation

@pierlon
Copy link
Contributor

@pierlon pierlon commented Aug 5, 2021

No description provided.

@pierlon pierlon added the dependencies Pull requests that update a dependency file label Aug 5, 2021
@pierlon pierlon enabled auto-merge August 5, 2021 00:02
@pierlon pierlon disabled auto-merge August 5, 2021 00:07
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2021

Plugin builds for 96d0bdc are ready 🛎️!

@westonruter
Copy link
Member

westonruter commented Aug 5, 2021

Oh, you should now be able to revert #6464 #6476.

@pierlon
Copy link
Contributor Author

pierlon commented Aug 9, 2021

Turns out the React version mismatch was due to an outdated package-lock.json. Removing it and re-locking the dependencies resolved the issue (see a112bf9).

@pierlon
Copy link
Contributor Author

pierlon commented Aug 9, 2021

Oh, you should now be able to revert #6464.

@westonruter How so? I'm not sure what you mean.

@pierlon pierlon changed the title Update Gutenberg packages after v11.2.0 release Update Gutenberg packages after v11.2.1 release Aug 9, 2021
@westonruter
Copy link
Member

How so? I'm not sure what you mean.

Oops. I meant #6476! Because Gutenberg 11.2.0 fixed the PWA manifest icon issue (WordPress/gutenberg#33702).

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #6511 (96d0bdc) into develop (543aa27) will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6511      +/-   ##
=============================================
+ Coverage      75.18%   75.38%   +0.19%     
- Complexity      5934     5962      +28     
=============================================
  Files            190      239      +49     
  Lines          17916    18745     +829     
=============================================
+ Hits           13470    14130     +660     
- Misses          4446     4615     +169     
Flag Coverage Δ
javascript 78.92% <ø> (?)
php 75.22% <ø> (+0.04%) ⬆️
unit 75.22% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
assets/src/block-editor/helpers/index.js 39.28% <ø> (ø)
...block-validation/components/error/error-content.js 93.54% <ø> (ø)
...k-validation/components/error/error-panel-title.js 100.00% <ø> (ø)
...ets/src/block-validation/components/error/index.js 100.00% <ø> (ø)
...sets/src/block-validation/components/icon/index.js 100.00% <ø> (ø)
...alidation/components/sidebar-notification/index.js 100.00% <ø> (ø)
...dation/components/with-amp-toolbar-button/index.js 100.00% <ø> (ø)
...dation/hooks/use-validation-error-state-updates.js 85.07% <ø> (ø)
assets/src/common/helpers/index.js 91.52% <ø> (ø)
assets/src/components/amp-drawer/index.js 73.07% <ø> (ø)
... and 63 more

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this.

@pierlon pierlon merged commit 2df1d2a into develop Aug 9, 2021
@pierlon pierlon deleted the update/gutenberg-v11.2.0-packages branch August 9, 2021 20:13
@westonruter westonruter added this to the v2.2 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants