Skip to content

fix data type conflict (#306) #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2024
Merged

fix data type conflict (#306) #323

merged 3 commits into from
Feb 28, 2024

Conversation

hks2002
Copy link
Contributor

@hks2002 hks2002 commented Feb 26, 2024

No description provided.

@an-tao an-tao requested a review from marty1885 February 27, 2024 02:38
@marty1885
Copy link
Collaborator

Thanks for fixing it. I've one suggestion. Instead of using unsigned char, etc.. can we use fixed size types like uint8_t, uint32_t, etc..? In case we compile it on a platform where that has a different meaning.

@an-tao an-tao merged commit c922801 into an-tao:master Feb 28, 2024
@hks2002 hks2002 deleted the fix_data_type_conflict branch February 29, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marty1885 marty1885 marty1885 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hks2002 @marty1885 @an-tao