Skip to content

[JetNews] bump to alpha06 #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisbanes merged 2 commits into from
Oct 28, 2020
Merged

[JetNews] bump to alpha06 #258

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ff3687
[JetNews] bump to alpha06
objcode Oct 27, 2020
7119cdd
Fix unused modifier on BookmarkButton
Oct 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix unused modifier on BookmarkButton 
Change-Id: I58638e2378d42430cc25e14569af7d3f474fd2b2
  • Loading branch information
Chris Banes committed Oct 28, 2020
commit 7119cdd6454c3b9638c0f78f15adadf64eb40d6f
5 changes: 2 additions & 3 deletions JetNews/app/src/main/java/com/example/jetnews/ui/home/PostCards.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import androidx.compose.foundation.Text
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.preferredSize
import androidx.compose.material.AmbientEmphasisLevels
Expand Down Expand Up @@ -144,9 +143,9 @@ fun BookmarkButton(
) {
IconToggleButton(
checked = isBookmarked,
onCheckedChange = { onClick() }
onCheckedChange = { onClick() },
modifier = modifier
) {
modifier.fillMaxSize()
if (isBookmarked) {
Icon(asset = Icons.Filled.Bookmark)
} else {
Expand Down