[JetNews] Move AppDrawer Composable from JetnewsApp.kt to AppDrawer.kt #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takahirom
force-pushed
the
takahirom/move-app-drawer
branch
from
757b26e to
5118b65
Compare
Contributor
Author
|
I added space to commit message. |
takahirom
force-pushed
the
takahirom/move-app-drawer
branch
from
ac165fc to
16723f1
Compare
objcode
approved these changes
Nov 6, 2020
Contributor
|
@yrezgui can you include this with the alpha07 changes? |
takahirom
force-pushed
the
takahirom/move-app-drawer
branch
from
16723f1 to
8e2e052
Compare
takahirom
changed the title
Contributor
Author
|
I rebased and fixed the import conflict. (with b0e28ed#diff-098e0ebfb55fd1512e2e230dca256aaab9e14bdee57e7317f04dace7061d5803L21 ) |
Collaborator
|
@takahirom, can you create another PR targeting the |
Contributor
|
*targeting |
Contributor
Author
|
Of course :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the many high quality samples!
I'm currently considering how to split files when building an app with Compose.
So I noticed that AppDrawer() used to be called by JetnewsApp() and now it's called by HomeScreen() and InterestsScreen(), and that AppDrawer() stays in JetnewsApp.kt. (aafa9ad#diff-098e0ebfb55fd1512e2e230dca256aaab9e14bdee57e7317f04dace7061d5803L61 )
Therefore, I moved it.
And there were previews such as PreviewJetnewsApp() and PreviewJetnewsAppDark(), but since it was a function for previewing AppDrawer, I changed it to PreviewAppDrawer().