Enable R8 for all sample apps #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
LGTM, but I can't review my 'own' PR. |
chrisbanes
requested review from
JoseAlcerreca,
florina-muntenescu and
nickbutcher
nickbutcher
approved these changes
Nov 12, 2020
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from @christofferqa's PR: #281
This enables R8 (in full mode) for all sample apps.
The version of kotlinx.coroutines is bumped to 1.4.1 to fix some warnings about missing classes (Kotlin/kotlinx.coroutines@d2ed1d8).
The version of OkHttp is bumped to 4.9.0 in Jetcaster to allow repackaging into the top-level (square/okhttp@e18aa1a).