Skip to content

[Owl] Migrates navigation to navigation-compose #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoseAlcerreca merged 12 commits into from
Nov 24, 2020
Merged

[Owl] Migrates navigation to navigation-compose #287

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
474dc79
[Owl] Migrates to navigation-compose
JoseAlcerreca Oct 30, 2020
eb9c08b
Adressing comments
JoseAlcerreca Nov 3, 2020
88db781
Syntax
JoseAlcerreca Nov 3, 2020
67b00c8
Navigation cleanup, safe arguments
JoseAlcerreca Nov 5, 2020
2cb58c2
[Owl] Initial nav tests
JoseAlcerreca Nov 5, 2020
73657aa
Test cleanup
JoseAlcerreca Nov 6, 2020
8dbf05b
Merge remote-tracking branch 'github/dev_alpha08' into dev_owl_naviga…
JoseAlcerreca Nov 20, 2020
97ed758
Reverts navigation abstraction and fixes tests
JoseAlcerreca Nov 20, 2020
3bc7c1f
Enables tests for Owl in GHA
JoseAlcerreca Nov 20, 2020
d984804
Adressing review comments
JoseAlcerreca Nov 20, 2020
0ea81d8
Spotless ~_~
JoseAlcerreca Nov 20, 2020
b3aa476
Replaces popBackStack with navigateUp
JoseAlcerreca Nov 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Syntax 
Change-Id: I1203d3a7f5c58770d6f544ad2606c5b2828cabdf
  • Loading branch information
@JoseAlcerreca
JoseAlcerreca committed Nov 3, 2020
commit 88db781642c2ba9f34b6712a44aeacbf1aab79ff
5 changes: 3 additions & 2 deletions Owl/app/src/main/java/com/example/owl/ui/OwlApp.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ fun OwlApp(backDispatcher: OnBackPressedDispatcher) {
composable(Destinations.Courses) {
Courses(actions.selectCourse)
}
composable(Destinations.Courses + "/{${Destinations.CoursesArgs.CourseId}}") {
backStackEntry ->
composable(
Destinations.Courses + "/{${Destinations.CoursesArgs.CourseId}}"
) { backStackEntry ->
val courseId = requireNotNull(backStackEntry.arguments)
.getLong(Destinations.CoursesArgs.CourseId)
CourseDetails(
Expand Down