Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
1c5d294
[Jetchat] Moves to Scaffold and Compose drawer content
JoseAlcerreca Oct 26, 2020
1594539
[Jetchat] Adds new drawer and fixes back handling and navigation events
JoseAlcerreca Oct 27, 2020
66c5237
[Jetchat] Adds KI to README
JoseAlcerreca Oct 30, 2020
da5f4b7
[Jetchat] spotless and comments
JoseAlcerreca Oct 30, 2020
474dc79
[Owl] Migrates to navigation-compose
JoseAlcerreca Oct 30, 2020
42dadcc
Adressing comments
JoseAlcerreca Nov 3, 2020
eb9c08b
Adressing comments
JoseAlcerreca Nov 3, 2020
88db781
Syntax
JoseAlcerreca Nov 3, 2020
67b00c8
Navigation cleanup, safe arguments
JoseAlcerreca Nov 5, 2020
2cb58c2
[Owl] Initial nav tests
JoseAlcerreca Nov 5, 2020
73657aa
Test cleanup
JoseAlcerreca Nov 6, 2020
779cf9e
Enable R8 for all sample apps
christofferqa Nov 11, 2020
7080aaf
Merge pull request #284 from christofferqa/enable_r8
chrisbanes Nov 12, 2020
3fd0412
[JetNews] Move AppDrawer Composable from JetnewsApp.kt to AppDrawer.kt
takahirom Nov 12, 2020
eca468c
Merge pull request #285 from takahirom/takahirom/move-app-drawer
yrezgui Nov 19, 2020
8dbf05b
Merge remote-tracking branch 'github/dev_alpha08' into dev_owl_naviga…
JoseAlcerreca Nov 20, 2020
97ed758
Reverts navigation abstraction and fixes tests
JoseAlcerreca Nov 20, 2020
3bc7c1f
Enables tests for Owl in GHA
JoseAlcerreca Nov 20, 2020
d984804
Adressing review comments
JoseAlcerreca Nov 20, 2020
0ea81d8
Spotless ~_~
JoseAlcerreca Nov 20, 2020
b3aa476
Replaces popBackStack with navigateUp
JoseAlcerreca Nov 24, 2020
cb1cf99
Merge pull request #287 from JoseAlcerreca/dev_owl_navigation_alpha08
JoseAlcerreca Nov 24, 2020
0b1326a
Fixes text opacity in JetchatAppBar
JoseAlcerreca Nov 25, 2020
e7e9a99
Merge pull request #292 from JoseAlcerreca/jetchat_fix_channel_name
JoseAlcerreca Nov 25, 2020
1b34722
[Jetnews] Bump to alpha08
yrezgui Nov 26, 2020
abf3745
[Jetnews] Remove old dependency
yrezgui Nov 26, 2020
785214a
[Jetnews] Use single name imports
yrezgui Nov 26, 2020
0ac866c
[Jetnews] Use single name imports
yrezgui Nov 26, 2020
4d15971
[Jetnews] Fix mistakes
yrezgui Nov 26, 2020
dfc05cf
[Jetnews] Update snapshot to 6995125
yrezgui Nov 27, 2020
7b5f131
[Rally] Updates to snapshot 6995125
JoseAlcerreca Nov 27, 2020
9d00eae
[Jetnews] Update testing dependency imports
yrezgui Nov 30, 2020
b7f9f5e
[Jetnews] Apply Spotless changes
yrezgui Nov 30, 2020
2ce683c
[Jetnews] Ignore tests causing CI issue
yrezgui Nov 30, 2020
4f03f82
[Jetchat] Updates to build 6995125
JoseAlcerreca Nov 30, 2020
f4541f8
Merge branch 'dev_alpha08' into rally_alpha08
yrezgui Nov 30, 2020
2b9965e
[Crane] Update to snapshot 6995125
JolandaVerhoef Nov 30, 2020
25297ff
[Jetchat] Moves to ComposeView.setContent and spotless
JoseAlcerreca Nov 30, 2020
0d0af95
[Jetchat] spotless again
JoseAlcerreca Nov 30, 2020
c524526
Merge branch 'jetchat_alpha08' into dev_jetchat_androidview
JoseAlcerreca Nov 30, 2020
160b32a
[Jetchat] Bad use of ComposeView.setContent
JoseAlcerreca Nov 30, 2020
ce476e0
Merge branch 'jetchat_alpha08' into dev_jetchat_androidview
JoseAlcerreca Nov 30, 2020
2161dbe
Lint: ambient naming
JoseAlcerreca Nov 30, 2020
f23955a
Update to snapshot 6994167.
nickbutcher Nov 25, 2020
467c062
Migrate to accompanist-insets.
nickbutcher Nov 25, 2020
9431ca2
Update to snapshot 7001724.
nickbutcher Nov 30, 2020
6c3e43c
Spotless.
nickbutcher Nov 30, 2020
7e93cad
Merge pull request #297 from JoseAlcerreca/jetchat_alpha08
JoseAlcerreca Dec 1, 2020
d7617b0
Merge branch 'jetchat_alpha08' into dev_jetchat_androidview
JoseAlcerreca Dec 1, 2020
855c628
Merge branch 'jetchat_alpha08' into dev_jetchat_androidview
JoseAlcerreca Dec 1, 2020
717dad8
Removes known issue from README as it was fixed
JoseAlcerreca Dec 1, 2020
c6a0740
Merge branch 'dev_jetchat_androidview' of github.com:JoseAlcerreca/co…
JoseAlcerreca Dec 1, 2020
bf3ffb0
Merge branch 'dev_alpha08' into nb/js_alpha08
nickbutcher Dec 1, 2020
f4fa9b2
Merge pull request #299 from android/nb/js_alpha08
nickbutcher Dec 1, 2020
852df71
[Owl] Update to snapshot 7001724.
nickbutcher Dec 1, 2020
726120b
[Jetnews] Upgrade to 7001724 snapshot
yrezgui Dec 1, 2020
1cd4dca
Update to Compose SNAPSHOT 7001724 (#303)
chrisbanes Dec 2, 2020
014e01a
[Jetsurvey] Updating to alpha08
florina-muntenescu Dec 2, 2020
f74451d
Fix default modifier on CourseListItem.
nickbutcher Dec 2, 2020
c88ca96
Merge branch 'dev_alpha08' into nb/owl_alpha08
nickbutcher Dec 2, 2020
532bc1f
Fix tests.
nickbutcher Dec 2, 2020
c9f8bc7
Merge branch 'nb/owl_alpha08' of github.com:android/compose-samples i…
nickbutcher Dec 2, 2020
b2db25d
Merge pull request #302 from android/nb/owl_alpha08
nickbutcher Dec 2, 2020
2212b42
Merge branch 'dev_alpha08' into fm/jetsurvey_alpha08
yrezgui Dec 2, 2020
88e8a96
Merge branch 'dev_alpha08' into rally_alpha08
yrezgui Dec 2, 2020
f08f54b
Merge branch 'dev_alpha08' into jetnews_alpha08
yrezgui Dec 2, 2020
b215d98
Merge pull request #294 from yrezgui/jetnews_alpha08
yrezgui Dec 2, 2020
98d77d9
Merge branch 'dev_alpha08' into fm/jetsurvey_alpha08
yrezgui Dec 2, 2020
62f7bd2
Merge pull request #304 from android/fm/jetsurvey_alpha08
yrezgui Dec 2, 2020
293e8ae
Merge branch 'dev_alpha08' into dev_jetchat_androidview
yrezgui Dec 2, 2020
a32e296
Merge branch 'dev_alpha08' into rally_alpha08
yrezgui Dec 2, 2020
4954d07
Merge branch 'dev_alpha08' into jv/cr_alpha08
yrezgui Dec 2, 2020
14c05d8
Merge pull request #295 from JoseAlcerreca/rally_alpha08
yrezgui Dec 2, 2020
760f796
Merge branch 'dev_alpha08' into jv/cr_alpha08
yrezgui Dec 2, 2020
356a528
Merge branch 'dev_alpha08' into dev_jetchat_androidview
yrezgui Dec 2, 2020
5c6b069
[Crane] Fix review comments
JolandaVerhoef Dec 3, 2020
28b262f
Merge pull request #298 from android/jv/cr_alpha08
JolandaVerhoef Dec 3, 2020
a8d2462
[Jetchat] Moved back to LiveData
JoseAlcerreca Dec 3, 2020
18219a0
Removes confusing comment
JoseAlcerreca Dec 3, 2020
d4b97ad
[Crane] Add Maps KTX library and adding Maps package within <queries>…
arriolac Dec 3, 2020
d4884aa
Spotless
JoseAlcerreca Dec 3, 2020
f658d03
Merge pull request #301 from JoseAlcerreca/dev_jetchat_androidview
JoseAlcerreca Dec 3, 2020
64b4d98
[Jetchat] Update to be edge-to-edge and add animated IME support (#306)
chrisbanes Dec 3, 2020
6df7995
[All] Update to Compose 1.0.0-alpha08
yrezgui Dec 3, 2020
3ec9bca
Upgrade to Java 11
yrezgui Dec 3, 2020
993bb2e
Upgrade to Java 11 for all samples
yrezgui Dec 3, 2020
c94b625
Merge pull request #307 from yrezgui/dev_alpha08
yrezgui Dec 3, 2020
487c636
[All] Upgrade samples to AGP 7.0.0-alpha02
yrezgui Dec 3, 2020
65777ad
Update all GitHub actions to use Java 11
yrezgui Dec 3, 2020
03965b2
Merge pull request #310 from yrezgui/agp-update
yrezgui Dec 3, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Owl] Migrates to navigation-compose
  • Loading branch information
JoseAlcerreca committed Oct 30, 2020
commit 474dc79a8a9b586f2324f2a6fe48baade57dc63f
1 change: 1 addition & 0 deletions Owl/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ dependencies {
implementation Libs.Kotlin.stdlib

implementation Libs.AndroidX.coreKtx
implementation Libs.AndroidX.navigation

implementation Libs.AndroidX.Compose.runtime
implementation Libs.AndroidX.Compose.foundation
Expand Down
31 changes: 10 additions & 21 deletions Owl/app/src/main/java/com/example/owl/ui/NavGraph.kt
Original file line number Diff line number Diff line change
Expand Up @@ -16,37 +16,26 @@

package com.example.owl.ui

import android.os.Parcelable
import androidx.compose.runtime.Immutable
import com.example.owl.ui.utils.Navigator
import kotlinx.android.parcel.Parcelize
import androidx.navigation.NavHostController
import androidx.navigation.compose.navigate

/**
* Models the screens in the app and any arguments they require.
*/
sealed class Destination : Parcelable {
@Parcelize
object Onboarding : Destination()

@Parcelize
object Courses : Destination()

@Immutable
@Parcelize
data class Course(val courseId: Long) : Destination()
object Destinations {
const val Onboarding = "Onboarding_dest_key"
const val Courses = "Courses_dest_key"
const val CourseDetails = "Courses_dest_key"
}

/**
* Models the navigation actions in the app.
*/
class Actions(navigator: Navigator<Destination>) {
class Actions(navController: NavHostController) {
val onboardingComplete: () -> Unit = {
navigator.navigate(Destination.Courses)
navController.navigate(Destinations.Courses)
}
val selectCourse: (Long) -> Unit = { courseId: Long ->
navigator.navigate(Destination.Course(courseId))
navController.navigate(Destinations.CourseDetails + "/$courseId")
}
val upPress: () -> Unit = {
navigator.back()
navController.popBackStack()
}
}
34 changes: 18 additions & 16 deletions Owl/app/src/main/java/com/example/owl/ui/OwlApp.kt
Original file line number Diff line number Diff line change
Expand Up @@ -17,38 +17,40 @@
package com.example.owl.ui

import androidx.activity.OnBackPressedDispatcher
import androidx.compose.animation.Crossfade
import androidx.compose.runtime.Composable
import androidx.compose.runtime.Providers
import androidx.compose.runtime.remember
import androidx.compose.runtime.savedinstancestate.rememberSavedInstanceState
import androidx.navigation.compose.NavHost
import androidx.navigation.compose.composable
import androidx.navigation.compose.rememberNavController
import com.example.owl.ui.course.CourseDetails
import com.example.owl.ui.courses.Courses
import com.example.owl.ui.onboarding.Onboarding
import com.example.owl.ui.utils.AmbientBackDispatcher
import com.example.owl.ui.utils.Navigator
import com.example.owl.ui.utils.ProvideDisplayInsets
import com.example.owl.ui.utils.ProvideImageLoader

@Composable
fun OwlApp(backDispatcher: OnBackPressedDispatcher) {
@Suppress("RemoveExplicitTypeArguments")
val navigator: Navigator<Destination> = rememberSavedInstanceState(
saver = Navigator.saver<Destination>(backDispatcher)
) {
Navigator(Destination.Onboarding, backDispatcher)
}
val actions = remember(navigator) { Actions(navigator) }

Providers(AmbientBackDispatcher provides backDispatcher) {
ProvideDisplayInsets {
ProvideImageLoader {
Crossfade(navigator.current) { destination ->
when (destination) {
Destination.Onboarding -> Onboarding(actions.onboardingComplete)
Destination.Courses -> Courses(actions.selectCourse)
is Destination.Course -> CourseDetails(
destination.courseId,
val navController = rememberNavController()

val actions = remember(navController) { Actions(navController) }
NavHost(navController = navController, startDestination = Destinations.Onboarding) {
composable(Destinations.Onboarding) {
Onboarding(actions.onboardingComplete)
}
composable(Destinations.Courses) {
Courses(actions.selectCourse)
}
composable(Destinations.CourseDetails + "/{courseId}") { backStackEntry ->
val courseId = backStackEntry.arguments?.getLong("courseId")
?: throw IllegalArgumentException("No course ID provided")
CourseDetails(
courseId,
actions.selectCourse,
actions.upPress
)
Expand Down
49 changes: 0 additions & 49 deletions Owl/app/src/main/java/com/example/owl/ui/utils/Navigation.kt
Original file line number Diff line number Diff line change
Expand Up @@ -16,61 +16,12 @@

package com.example.owl.ui.utils

import android.os.Parcelable
import androidx.activity.OnBackPressedCallback
import androidx.activity.OnBackPressedDispatcher
import androidx.compose.runtime.Composable
import androidx.compose.runtime.onCommit
import androidx.compose.runtime.remember
import androidx.compose.runtime.savedinstancestate.listSaver
import androidx.compose.runtime.staticAmbientOf
import androidx.compose.runtime.toMutableStateList

/**
* A simple navigator which maintains a back stack.
*/
class Navigator<T : Parcelable> private constructor(
initialBackStack: List<T>,
backDispatcher: OnBackPressedDispatcher
) {
constructor(
initial: T,
backDispatcher: OnBackPressedDispatcher
) : this(listOf(initial), backDispatcher)

private val backStack = initialBackStack.toMutableStateList()
private val backCallback = object : OnBackPressedCallback(canGoBack()) {
override fun handleOnBackPressed() {
back()
}
}.also { callback ->
backDispatcher.addCallback(callback)
}
val current: T get() = backStack.last()

fun back() {
backStack.removeAt(backStack.lastIndex)
backCallback.isEnabled = canGoBack()
}

fun navigate(destination: T) {
backStack += destination
backCallback.isEnabled = canGoBack()
}

private fun canGoBack(): Boolean = backStack.size > 1

companion object {
/**
* Serialize the back stack to save to instance state.
*/
fun <T : Parcelable> saver(backDispatcher: OnBackPressedDispatcher) =
listSaver<Navigator<T>, T>(
save = { navigator -> navigator.backStack.toList() },
restore = { backstack -> Navigator(backstack, backDispatcher) }
)
}
}

/**
* An effect for handling presses of the device back button.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ object Libs {

object AndroidX {
const val coreKtx = "androidx.core:core-ktx:1.5.0-alpha04"
const val navigation = "androidx.navigation:navigation-compose:1.0.0-alpha01"

object Compose {
const val snapshot = ""
Expand Down