Skip to content

More code style fixes #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andywer merged 1 commit into from
May 30, 2018
Merged

More code style fixes #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
More code style fixes
  • Loading branch information
@dazzy
dazzy committed May 30, 2018
commit 834a2f00c73f7d81411c4e02d2b18bb280bfecd4
6 changes: 3 additions & 3 deletions src/Console/ExportCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ protected function getOptions()
public function handle()
{
$noCache = (bool)$this->option('no-cache');
if ($noCache == true) $this->line('Exporting messages and config...');
if ($noCache === true) $this->line('Exporting messages and config...');
else $this->line('Refreshing and exporting the message and config cache...');

$locales = Config::get('js-localization.locales');
Expand All @@ -63,11 +63,11 @@ public function handle()
throw new ConfigException('Please set the "locales" config! See https://github.com/andywer/laravel-js-localization#configuration');
}

if ($noCache == false) MessageCachingService::refreshCache();
if ($noCache === false) MessageCachingService::refreshCache();
$messagesFilePath = $this->createPath('messages.js');
$this->generateMessagesFile($messagesFilePath, $noCache);

if ($noCache == false) ConfigCachingService::refreshCache();
if ($noCache === false) ConfigCachingService::refreshCache();
$configFilePath = $this->createPath('config.js');
$this->generateConfigFile($configFilePath, $noCache);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Facades/ConfigCachingService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*
* @method static void refreshCache()
* @method static \DateTime getLastRefreshTimestamp()
* @method static string getConfigJson()
* @method static string getConfigJson(bool $noCache = false)
* @method static bool isDisabled()
* @method static void public function refreshCache()
*/
Expand Down
2 changes: 1 addition & 1 deletion src/Facades/MessageCachingService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
*
* @method static void refreshCache()
* @method static \DateTime getLastRefreshTimestamp()
* @method static string getMessagesJson()
* @method static string getMessagesJson(bool $noCache = false)
* @method static void public function refreshCache()
*/
class MessageCachingService extends Facade
Expand Down