typeahead expects li in template

[frfancha]

The code:
target = popUpEl.find('li')[scope.activeIdx];
target.parentNode.scrollTop = target.offsetTop;
in typeahead.js in master fails (target is undefined) if the template doesn't contains -li- (we use -tr- instead of -li- and -table- instead of -ul- by typeahead-popup-template-url).

When the developper tool is not opened in the browser everything runs fine despite the error.

If using -li- is officialy required in custom templates, then this is a feature request to allow other html elements, and if -li- is already allowed today then it is to report the bug.

[icfantv]

@frfancha, please be respectful of our time by adhering to our issue template.

additionally, please use MD formatting to make your issue text more readable.

[pkozlowski-opensource]

This is a valid issue. We shouldn't be doing DOM querying like this as it limits possibilities for template swapping.

[pkozlowski-opensource]

Offensive code is here:

bootstrap/src/typeahead/typeahead.js

Lines 409 to 415 in f88067a

	target = popUpEl.find('li')[scope.activeIdx];
	target.parentNode.scrollTop = target.offsetTop;
	break;
	case 40:
	scope.activeIdx = (scope.activeIdx + 1) % scope.matches.length;
	scope.$digest();
	target = popUpEl.find('li')[scope.activeIdx];

[wesleycho]

We probably should change it to query for a class instead of a tag.

[RobJacobs]

Was looking at creating a PR for this, was wondering if using:

[role="option"]

for the query selector would work.