feat(typeahead): handles min-length of 0

[zacronos]

Correctly handles min-length of 0 (i.e. will keep typeahead popup open even when all input has been deleted).

[chrisirhc]

Thank you @zacronos , I'm working on integrating this into #888.

[rvanbaalen]

This is some good work. @chrisirhc are you still planning in integrating this (since the PR you mentioned is closed)?

Otherwise I would vote to add this in a 0.13.x release -- can imagine people would use this.

In the meanwhile, @zacronos can you update the PR so we can merge it with the current master?

[zacronos]

@rvanbaalen, sure, I'll take a look and see what it takes to get it in line with master.

[rvanbaalen]

Awesome. Much appreciated.

---

This email was sent from my iPhone and therefore subject to typos and other inaccuracies.

On 29 apr. 2015, at 18:39, Joe Ibershoff notifications@github.com wrote:

@rvanbaalen, sure, I'll take a look and see what it takes to get it in line with master.

—
Reply to this email directly or view it on GitHub.

[zacronos]

@rvanbaalen, I apologize, but I've never gotten the hang of rebasing and whatnot in order to keep updated PRs from showing a huge list of modified files that aren't really modified. So to keep things clean and straightforward, I've just opened a new PR with the updates: #3600

[rvanbaalen]

No problem. You closed the old one and referenced the new one. Perfect.

[dmitriz]

Should it not also check if the input is focus'd?
Otherwise any typeahead directive would stay open?

[zacronos]

@dmitriz, please comment on the new PR for this feature instead of this one (this PR is closed): https://github.com/angular-ui/bootstrap/pull/3600/files Though the new PR is identical in terms of functionality, I did write a few lines differently for readability.

[dmitriz]

sorry - left tabs open overnight and didn't notice it was closed - my bad! :)