This repository was archived by the owner on May 29, 2019. It is now read-only.
fix(datepicker): Parse date from $viewValue instead of $modelValue #3358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows the use of
datepickerin conjunction with anngModelControllerthat has custom formatters and parsers to translate between$modelValueand$viewValue.In my particular use case, my model is a custom date value object. I'd like to bind it directly to the
datepickerand handle the translation between the custom date value format and aDateobject, with a formatter and a parser that's added to thengModelController. This might be a somewhat obscure use, but it is valid and saves doing manual$scope.$watch's and so on.Here's a demonstration of my use case: http://jsfiddle.net/dy8vvyey/7/
The
datepickerdirective, being the view, should really use the$viewValue, and it should be up to the user of the directive what the$modelValuelooks like.