This repository was archived by the owner on May 29, 2019. It is now read-only.
[kaidjohnson] Fix up dateparser support for 12 hour datetime format.#4117
Closed
kaidjohnson wants to merge 1 commit intoangular-ui:masterfrom
kaidjohnson:kaidjohnson-dateparser-updates
Closed
[kaidjohnson] Fix up dateparser support for 12 hour datetime format.#4117kaidjohnson wants to merge 1 commit intoangular-ui:masterfrom kaidjohnson:kaidjohnson-dateparser-updates
kaidjohnson wants to merge 1 commit intoangular-ui:masterfrom
kaidjohnson:kaidjohnson-dateparser-updates
Conversation
Contributor
|
@kaidjohnson please add the relevant functional test(s) for this and update/rebase/squash your PR. thanks. |
src/dateparser/dateparser.js
Outdated
Contributor
There was a problem hiding this comment.
Revert this change - this is no different than the previous version, as tested here.
Author
|
Thanks @icfantv and @wesleycho -- I've added tests, removed redundant {1}, and corrected AM/PM parsing issue discovered during tests. Also updated plunkr |
wesleycho
added
component: datepicker
component: timepicker
and removed
needs: PR test(s)
needs: work
labels
Contributor
|
LGTM - good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a date format that includes a 12-hour time format (eg. dd MMMM yyyy hh:mma) can result in a permanent invalid parsing of the value.
I've created a plunk to demonstrate the issue (try manually deleting the 'M' from 'PM' then putting the 'M' back. It becomes invalid without the M but never is valid again when the M is restored.):
http://plnkr.co/edit/CvJgnoCE08XGlDbVQka8?p=preview
Here's the same plunkr, but with the fix found in this PR:
http://plnkr.co/edit/uTKEjRFcY3CsWDHyZ0bZ?p=preview