fix(tabset): preserve tabset class attribute#584
Conversation
this should fix #581
|
I think this is more convenient for user to specify same class attribute as twitter bootstrap uses. Thus user of angular-bootstrap shouldn`t learn specific attributes of tabset directive. But this is only my opinion. |
|
@bk1te @ajoslin is a master here so I will let him decide. Just few notes here:
|
|
looks good to me :-) Allowing css classes on the tabset is definitely a good thing to have. I'll merge it in a few minutes |
|
@ajoslin @pkozlowski-opensource I think you can add |
|
OK. Tests don't fail and demo works fine if we do |
|
Yeah. You're right. |
* replace is now set to true in the tabset directive options
|
Fixed in 8868f23, did the replace method instead. Thanks @bk1te for bringing this issue up :-) |
|
thnks for resolving this issue |
this should fix #581