Skip to content

fix(@angular-devkit/build-angular): validate scripts and styles bundleName #20361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

fix(@angular-devkit/build-angular): validate scripts and styles bundleName #20361

merged 1 commit into from
Mar 29, 2021

Conversation

@alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Mar 23, 2021

Closes #20360

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Mar 23, 2021
@alan-agius4 alan-agius4 requested a review from clydin March 23, 2021 17:32
@google-cla google-cla bot added the cla: yes label Mar 23, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 24, 2021
@filipesilva filipesilva merged commit 51cb318 into angular:master Mar 29, 2021
@alan-agius4 alan-agius4 deleted the bundle-name-validate branch March 29, 2021 14:59
Splaktar added a commit to DevIntent/material.angular.io that referenced this pull request Apr 7, 2021
@Splaktar
build: update to Angular and CLI v12 next.7 and Components v12 next.5
a0f4829 
- fix typing change in `ActivatedRoute.fragment`
- fix [breaking change](angular/angular-cli#20361)
  to no longer allow the styles `bundleName` to include a path in the ng build config
@Splaktar Splaktar mentioned this pull request Apr 7, 2021
Merged
Splaktar added a commit to DevIntent/material.angular.io that referenced this pull request Apr 8, 2021
@Splaktar
build: update to Angular and CLI v12 next.7 and Components v12 next.5
fb4a322 
- fix typing change in `ActivatedRoute.fragment`
- fix [breaking change](angular/angular-cli#20361)
  to no longer allow the styles `bundleName` to include a path in the ng build config
Splaktar added a commit to angular/material.angular.io that referenced this pull request Apr 8, 2021
@Splaktar
build: update to Angular and CLI v12 next.7 and Components v12 next.5
8583f02 
- fix typing change in `ActivatedRoute.fragment`
- fix [breaking change](angular/angular-cli#20361)
  to no longer allow the styles `bundleName` to include a path in the ng build config
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 29, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clydin clydin clydin approved these changes

+1 more reviewer

@kyliau kyliau kyliau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Relative url() paths in styles are resolved incorrectly for non-root directory

4 participants

@alan-agius4 @kyliau @clydin @filipesilva