Skip to content

fix(build): Use static files for styles #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimitndiaye wants to merge 7 commits into from
Closed

fix(build): Use static files for styles #2646

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
099d21b
Add extract-text-webpack-plugin dependency
jimitndiaye Oct 13, 2016
ca966bf
Use extract-text-plugin to extract css bundle for production builds.
jimitndiaye Oct 13, 2016
ec26e19
Added e2e tests for prod build covering style bundling for css, less …
jimitndiaye Oct 18, 2016
78f8610
Update production build e2e test to expect 32 character content hash …
jimitndiaye Oct 18, 2016
9bec7c9
fix paths for styles.less and styles.scss in css e2e test
jimitndiaye Oct 18, 2016
b418afd
use glob to find path to hashed styles bundle for prod build
jimitndiaye Oct 18, 2016
0a6b40d
chore(style): remove unused fs import
jimitndiaye Oct 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update production build e2e test to expect 32 character content hash … 
…in style bundle file name
  • Loading branch information
@jimitndiaye
jimitndiaye committed Oct 18, 2016
commit 78f8610c7416181f612ee4c1edfd8c365272166b
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/prod-build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function() {
.then(() => expectFileToExist(join(process.cwd(), 'dist')))
// Check for cache busting hash script src
.then(() => expectFileToMatch('dist/index.html', /main\.[0-9a-f]{20}\.bundle\.js/))
.then(() => expectFileToMatch('dist/index.html', /styles\.[0-9a-f]{20}\.bundle\.css/))
.then(() => expectFileToMatch('dist/index.html', /styles\.[0-9a-f]{32}\.bundle\.css/))

// Check that the process didn't change local files.
.then(() => expectGitToBeClean())
Expand Down