Skip to content

Backwards warning that global CLI is greater version than local CLI #… #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hansl merged 1 commit into from
Feb 3, 2017
Merged

Backwards warning that global CLI is greater version than local CLI #… #4341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Backwards warning that global CLI is greater version than local CLI #… 
…4337: Fixed comparation of versions (inverse).
  • Loading branch information
m500574 Michael Füser committed Feb 2, 2017
commit 7e78b56ee376efd1cc64ac95c80b24a96c4beac1
2 changes: 1 addition & 1 deletion packages/@angular/cli/bin/ng
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ resolve('@angular/cli', { basedir: process.cwd() },

try {
localVersion = _fromPackageJson();
shouldWarn = localVersion && globalVersion.compare(localVersion) < 0;
shouldWarn = localVersion && globalVersion.compare(localVersion) > 0;
} catch (e) {
console.error(e);
shouldWarn = true;
Expand Down