This repository was archived by the owner on Feb 26, 2024. It is now read-only.
fix(index-async): fix inlining of angular-loader into index-async.html
#343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…html` Previously, `angular-loader` was never inlined into `index-async.html`, because running `sed` with a multiline RegExp fails to match anything, since `sed` matches per line. Using the `fs` module directly, solves the issues. (Now, we no longer depend on `shelljs`.) Closes angular#309
gkalpak
force-pushed
the
fix-index-async
branch
2 times, most recently
from
d7083e8 to
4fc738b
Compare
When using `'...'.replace(regex, replacement)`, any instances of `$$` inside `replacement` will be converted to `$` (see [mdn](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter). Thus, for example `$$minErr` and `$$moduleName` are converted to `$minErr` and `$moduleName`. This commit fixes it, by first using `'...'.split(regex).join(replacement)` instead. Fixes angular#283 Closes angular#286
petebacondarwin
referenced
this pull request
Jun 17, 2016
When using `'...'.replace(regex, replacement)`, any instances of `$$` inside `replacement` will be converted to `$` (see [mdn](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replace#Specifying_a_string_as_a_parameter). Thus, for example `$$minErr` and `$$moduleName` are converted to `$minErr` and `$moduleName`. This commit fixes it, by first using `'...'.split(regex).join(replacement)` instead. Fixes #283 Closes #286
Contributor
|
Closed via a223b77 |
This was referenced Jun 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
angular-loaderwas never inlined intoindex-async.html, because runningsedwith a multiline RegExp fails to match anything, sincesedmatches per line. Using thefsmodule directly, solves the issues.(Now, we no longer depend on
shelljs.)Closes #309
Also, when using
'...'.replace(regex, replacement), any instances of$$insidereplacementwill beconverted to
$(see mdn.Thus, for example
$$minErrand$$moduleNameare converted to$minErrand$moduleName.The 2nd commit fixes it, by first converting
$$to$$$$.Fixes #283
Closes #286