chore(*): refactor, improve, upgrade #444

gkalpak · 2018-10-26T15:41:16Z

Main themes:

Improve file/directory layout.
Switch from bower to npm.
Upgrade all dependencies.

Incorporates #361 and #390.
Partially addresses #334.

…n best practices Partly addresses angular#334.

googlebot · 2018-10-26T15:41:19Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

gkalpak · 2018-10-26T16:44:16Z

Not sure why Travis isn't triggered. I verified this on my fork: https://travis-ci.org/gkalpak/angular-seed/builds/446783519

petebacondarwin · 2018-10-30T08:11:24Z

README.md

 to quickly bootstrap your angular webapp projects and dev environment for these projects.

-The seed contains a sample AngularJS application and is preconfigured to install the Angular
+The seed contains a sample AngularJS application and is preconfigured to install the AngularJS


petebacondarwin · 2018-10-30T08:12:48Z

README.md

-Behind the scenes this will also call `bower install`. After that, you should find out that you have
-two new folders in your project.
+Behind the scenes this will also call `npm run copy-libs`, which copies the AngularJS files and
+other frontend dependencies. After that, you should find out that you have two new directories in


front end is two words (possibly hyphenated).

petebacondarwin

why rename the folder components to core?

mgol

See comments.

mgol · 2018-10-30T08:57:39Z

.travis.yml

-  - npm run test-single-run
-  - (npm start > /dev/null &) && (npm run protractor)
+  - npm run test-single-run;
+  - (npm start > /dev/null &) && npm run protractor;


Semicolons are routinely not used in Bash scripts as a new line serves the same purpose and there are no ASI hazards as in JS. I'd leave it as it was.

mgol · 2018-10-30T08:58:13Z

.travis.yml

-  - npm install
+before_install:
+  - export DISPLAY=":99.0";
+  - sh -e /etc/init.d/xvfb start;


Is this whole block needed now that we can use Chrome Headless?

I was a little on the fence on that one. (Might be a little too magic for beginners.)
But I am not opposed. Let's give it a go.

mgol · 2018-10-30T08:59:41Z

README.md

 ```

-Then you can start your own development web server to serve static files from a folder by running:
+Then you can start your own development web server to serve static files from any folder by running:


Don't use "any"! (a bad TypeScript joke)

How about unknown? 😛

mgol · 2018-10-30T09:11:25Z

why rename the folder components to core?

@petebacondarwin See #334.

Includes the following changes: - Run tests on macOS and Windows as well. - Run tests against the current Node.js LTS version (v10.x). - Cache npm cache directory between builds.

See angular/webdriver-manager#303 for details.

gkalpak · 2018-10-30T10:14:45Z

Addressed comments.
Added a couple of fixup commits and also switched to Chrome headless on CI.
Ran Travis on my fork.

@petebacondarwin, @mgol: PTAL

petebacondarwin

I see you are committed to "core"

mgol

Looks good!

Narretz · 2018-10-30T10:43:24Z

Looks like Travis is not enabled for this repo - it must have been disabled some time in the last year: https://travis-ci.org/angular/angular-seed (says "This is not an active repository" for me)

petebacondarwin · 2018-10-30T10:44:44Z

And we don't have rights to turn it back on...

Related: angular/angular-seed#444

gkalpak added 2 commits October 26, 2018 18:38

refactor(*): rename files and directories to bring in-line with moder…

be0b98a

…n best practices Partly addresses angular#334.

chore(*): switch from bower to npm for frontend dependencies

10a4f37

Closes angular#385 Closes angular#389

This was referenced Oct 26, 2018

refactor(*): rename files and directories to bring in-line with modern best practices #361

Closed

chore(*): switch from bower to npm for frontend dependencies #390

Closed

chore: update the codebase (e.g. directory layout, file naming etc) #334

Closed

gkalpak closed this Oct 26, 2018

gkalpak reopened this Oct 26, 2018

gkalpak force-pushed the chore-upgrade-to-1.7.x branch 5 times, most recently from 55b6a25 to 68df4cf Compare October 26, 2018 16:36

petebacondarwin reviewed Oct 30, 2018

View reviewed changes

petebacondarwin approved these changes Oct 30, 2018

View reviewed changes

mgol reviewed Oct 30, 2018

View reviewed changes

gkalpak and others added 7 commits October 30, 2018 11:44

fixup! chore(*): switch from bower to npm for frontend dependencies

4e999e7

docs(*): use the name AngularJS rather than Angular

9d30bed

chore(*): upgrade all dependencies to latest versions

66e59e5

chore(*): check in package-lock.json

e48966d

chore(travis): simplify and improve config

204cb76

Includes the following changes: - Run tests on macOS and Windows as well. - Run tests against the current Node.js LTS version (v10.x). - Cache npm cache directory between builds.

fixup! chore(travis): simplify and improve config

cda81f3

chore(*): do not install WebDriver for Firefox to avoid error on CI

58a3c46

See angular/webdriver-manager#303 for details.

gkalpak force-pushed the chore-upgrade-to-1.7.x branch from 2358bb6 to 58a3c46 Compare October 30, 2018 09:46

chore(travis): use headless Chrome in tests

a02c9f2

petebacondarwin approved these changes Oct 30, 2018

View reviewed changes

mgol approved these changes Oct 30, 2018

View reviewed changes

gkalpak closed this in 5ff1cb4 Oct 30, 2018

gkalpak deleted the chore-upgrade-to-1.7.x branch October 30, 2018 11:38

gkalpak added a commit to gkalpak/angular-phonecat that referenced this pull request Oct 30, 2018

chore: switch from bower to npm for front end dependencies

6752585

Related: angular/angular-seed#444

gkalpak added a commit to gkalpak/angular-phonecat that referenced this pull request Oct 30, 2018

chore: switch from bower to npm for front end dependencies

b92ce19

Related: angular/angular-seed#444

gkalpak added a commit to gkalpak/angular-phonecat that referenced this pull request Oct 31, 2018

chore: switch from bower to npm for front end dependencies

623f7b2

Related: angular/angular-seed#444

gkalpak added a commit to gkalpak/angular-phonecat that referenced this pull request Nov 1, 2018

chore: switch from bower to npm for front end dependencies

2c7cf17

Related: angular/angular-seed#444

gkalpak mentioned this pull request Nov 1, 2018

chore(*): upgrade all dependencies, switch from bower to npm and other improvements angular/angular-phonecat#430

Merged

gkalpak added a commit to gkalpak/angular-phonecat that referenced this pull request Nov 2, 2018

chore: switch from bower to npm for front end dependencies

3224b47

Related: angular/angular-seed#444

gkalpak mentioned this pull request Nov 2, 2018

docs(tutorial): bring up-to-date with latest angular-phonecat/angular-seed angular/angular.js#16753

Closed

gkalpak added a commit to gkalpak/angular-phonecat that referenced this pull request Nov 5, 2018

chore: switch from bower to npm for front end dependencies

79f9cc9

Related: angular/angular-seed#444

gkalpak added a commit to gkalpak/angular-phonecat that referenced this pull request Nov 5, 2018

chore: switch from bower to npm for front end dependencies

552247a

Related: angular/angular-seed#444

gkalpak added a commit to angular/angular-phonecat that referenced this pull request Nov 15, 2018

chore: switch from bower to npm for front end dependencies

ad542e7

Related: angular/angular-seed#444

gkalpak added a commit to angular/angular-phonecat that referenced this pull request Nov 15, 2018

chore: switch from bower to npm for front end dependencies

8e13487

Related: angular/angular-seed#444

gkalpak added a commit to angular/angular-phonecat that referenced this pull request Nov 15, 2018

chore: switch from bower to npm for front end dependencies

bcd8da5

Related: angular/angular-seed#444

chore(*): refactor, improve, upgrade #444

chore(*): refactor, improve, upgrade #444

Uh oh!

Conversation

gkalpak commented Oct 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Oct 26, 2018

Uh oh!

gkalpak commented Oct 26, 2018

Uh oh!

petebacondarwin Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

petebacondarwin Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

mgol left a comment

Choose a reason for hiding this comment

Uh oh!

mgol Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

mgol Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

gkalpak Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

mgol Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

gkalpak Oct 30, 2018

Choose a reason for hiding this comment

Uh oh!

mgol commented Oct 30, 2018

Uh oh!

gkalpak commented Oct 30, 2018

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

mgol left a comment

Choose a reason for hiding this comment

Uh oh!

Narretz commented Oct 30, 2018

Uh oh!

petebacondarwin commented Oct 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gkalpak commented Oct 26, 2018 •

edited

Loading