Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngAria): do not scroll when pressing spacebar on custom buttons #16604

Closed
gkalpak wants to merge 3 commits into from
Closed

fix(ngAria): do not scroll when pressing spacebar on custom buttons #16604

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84f8de3
refactor(ngAria): clean up `accessible actions` tests
gkalpak Jun 16, 2018
8984708
fix(ngAria): do not scroll when pressing spacebar on custom buttons
gkalpak Jun 16, 2018
a0df567
fixup! fix(ngAria): do not scroll when pressing spacebar on custom bu…
gkalpak Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fix(ngAria): do not scroll when pressing spacebar on custom bu… 
…ttons
  • Loading branch information
@gkalpak
gkalpak committed Jun 18, 2018
commit a0df567ee2bf5ef4cdf1c104ebfadeff1069c20d
2 changes: 1 addition & 1 deletion test/ngAria/ariaSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ describe('$aria', function() {
clickEvents = [];
scope.onClick = jasmine.createSpy('onClick').and.callFake(function(evt) {
var nodeName = evt ? evt.target.nodeName.toLowerCase() : '';
var prevented = !!(evt && evt.defaultPrevented);
var prevented = !!(evt && evt.isDefaultPrevented());
clickEvents.push(nodeName + '(' + prevented + ')');
});
});
Expand Down