Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($location): avoid unnecessary $locationChange* events due to empty hash #16636

Closed
gkalpak wants to merge 9 commits into from
Closed

fix($location): avoid unnecessary $locationChange* events due to empty hash #16636

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7f524c4
refactor($location): minor changes (unused deps, exported globals, un…
gkalpak Jul 19, 2018
8f28de4
refactor($location): remove unnecessary capturing group in RegExp
gkalpak Jul 19, 2018
8053bc4
refactor($browser): correctly export helper used in specs
gkalpak Jul 19, 2018
bbf6900
test($location): add assertion
gkalpak Jul 19, 2018
b085893
fix($location): avoid unnecessary `$locationChange*` events due to em…
gkalpak Jul 19, 2018
c37c2e4
fixup! fix($location): avoid unnecessary `$locationChange*` events du…
gkalpak Jul 25, 2018
cdd1f42
fixup! fix($location): avoid unnecessary `$locationChange*` events du…
gkalpak Jul 25, 2018
d736771
fixup! fix($location): avoid unnecessary `$locationChange*` events du…
gkalpak Jul 26, 2018
c3ca532
fixup! fix($location): avoid unnecessary `$locationChange*` events du…
gkalpak Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor($location): remove unnecessary capturing group in RegExp
  • Loading branch information
@gkalpak
gkalpak committed Jul 25, 2018
commit 8f28de49265a59f59b5fb6011d1c494564f43a2f
2 changes: 1 addition & 1 deletion src/ng/location.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ function stripHash(url) {
}

function trimEmptyHash(url) {
Copy link
Contributor

@jbedard jbedard Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove some calls to this within this file now that $browser does it?

Copy link
Member Author

@gkalpak gkalpak Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

Note that is many places we trim the empty hash before using the returned url. (If we decide this fix is desired, I will remove those unnecessary calls.)

return url.replace(/(#.+)|#$/, '$1');
return url.replace(/#$/, '');
}


Expand Down