Skip to content

Conversation

@alan-agius4
Copy link
Contributor

@alan-agius4 alan-agius4 commented Apr 2, 2020

Related to angular/angular-cli#17372

This is to verify that all examples in AIO are complainant with strictTemplates setting.

@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release comp: docs-infra and removed state: WIP labels Apr 2, 2020
@ngbot ngbot bot added this to the needsTriage milestone Apr 2, 2020
@gkalpak gkalpak requested review from gkalpak and removed request for IgorMinar April 2, 2020 16:04
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

One question: Why limit it to master only, @alan-agius4?

@gkalpak gkalpak added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Apr 2, 2020
@alan-agius4
Copy link
Contributor Author

@gkalpak, we can target patch as well 🙂

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: major This PR is targeted for the next major release labels Apr 2, 2020
kara pushed a commit that referenced this pull request Apr 2, 2020
@kara kara closed this in 04f61c0 Apr 2, 2020
@alan-agius4 alan-agius4 deleted the enable-strict-templates-aio branch April 2, 2020 18:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants