docs(forms): fixes in forms documentation #37933
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bampakoa
changed the title
bampakoa
changed the title
AndrewKushnir
added
target: patch
AndrewKushnir
approved these changes
Jul 13, 2020
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Thanks for the fixes @bampakoa.
FYI I've rebased this PR to re-run CI (for some reasons it didn't run last time). Once CI run is completed, this PR would be ready for the merge.
Thank you.
AndrewKushnir
added
action: merge
Contributor
|
@bampakoa the |
Remove an article from the `Data flow in forms` section of the forms overview guide. The use of `the` and `a` together is not syntactically correct.
Fix two typos in the 'Building a template-driven form` that caused the guide to not be displayed correctly.
Contributor
Author
|
@AndrewKushnir thanks for the feedback! It is ready now 👍 |
AndrewKushnir
removed
the
action: cleanup
Contributor
|
Thanks for the updates @bampakoa, I'm marking this PR as ready for merge. Thank you. |
atscott
pushed a commit
that referenced
this pull request
Jul 14, 2020
Fix two typos in the 'Building a template-driven form` that caused the guide to not be displayed correctly. PR Close #37933
atscott
pushed a commit
that referenced
this pull request
Jul 14, 2020
Remove an article from the `Data flow in forms` section of the forms overview guide. The use of `the` and `a` together is not syntactically correct. PR Close #37933
atscott
pushed a commit
that referenced
this pull request
Jul 14, 2020
Fix two typos in the 'Building a template-driven form` that caused the guide to not be displayed correctly. PR Close #37933
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
Remove an article from the `Data flow in forms` section of the forms overview guide. The use of `the` and `a` together is not syntactically correct. PR Close angular#37933
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
Fix two typos in the 'Building a template-driven form` that caused the guide to not be displayed correctly. PR Close angular#37933
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information