Skip to content

fix(datepicker): add back MAT_DATE_LOCALE_PROVIDER #10602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2018
Merged

fix(datepicker): add back MAT_DATE_LOCALE_PROVIDER #10602

merged 1 commit into from
Mar 29, 2018

Conversation

mmalerba
Copy link
Contributor

Some people who are using custom date adapters were importing this to provide in their NgModule

@mmalerba mmalerba added pr: needs review target: patch This PR is targeted for the next patch release labels Mar 28, 2018
@mmalerba mmalerba requested a review from jelbourn March 28, 2018 16:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 28, 2018
@mmalerba mmalerba added this to the 6.0 milestone Mar 28, 2018
jelbourn
jelbourn approved these changes Mar 28, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Mar 28, 2018
@josephperrott josephperrott merged commit 7fd7ad3 into angular:master Mar 29, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @jelbourn @googlebot @josephperrott