build(bazel): add version stamping #10687
Conversation
googlebot
added
the
cla: yes
jelbourn
force-pushed
the
bazel-version-stamping
branch
3 times, most recently
from
8abd700 to
6a23a73
Compare
jelbourn
force-pushed
the
bazel-version-stamping
branch
from
6a23a73 to
555a631
Compare
| url = "https://github.com/bazelbuild/rules_nodejs/archive/0.6.0.zip", | ||
| strip_prefix = "rules_nodejs-0.6.0", | ||
| sha256 = "e8a2bb5ca51fbafb244bc507bcebcae33a63d969f47413b319a8dcce032845bf", | ||
| url = "https://github.com/bazelbuild/rules_nodejs/archive/99166f8eb7fc628ca561acf9f9a51a1c26edadad.zip", |
There was a problem hiding this comment.
do you need this labelled? 0.7.0 was from Friday and should have what you need
There was a problem hiding this comment.
It doesn't really need to be, I can update it next time around
| srcs = ["package.json"], | ||
| entry_point = "src/lib/public_api.js", | ||
| entry_point_name = "material", | ||
| globals = ROLLUP_GLOBALS, |
There was a problem hiding this comment.
check if the globals are out of date now that rxjs has only two entry points
There was a problem hiding this comment.
They should be good; this just captures the globals specific to our own packages
|
|
||
| # Output to a more coventional location | ||
| build --symlink_prefix=dist/bazel/ | ||
| # Configures script to do version stamping. |
There was a problem hiding this comment.
do you mean to remove symlink_prefix?
There was a problem hiding this comment.
Yeah, I meant to remove it a while ago and lost the change
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
@alexeagle this captures setting the version on the packages we produce, but our existing build system also has a placeholder for the version of Angular we depend on (since that's also used across multiple packages). I'll probably have to do something manually to the output of
ng_packageto deal with that, since it's pretty custom.