fix(overlay): centered flexible positioning not working in some browsers #10701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
andrewseguin,
jelbourn,
kara and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
flexible-positioning-flexbox-fix
branch
3 times, most recently
from
0534dd6 to
e8583d1
Compare
Currently using centering with the `FlexibleConnectedPositionStrategy` in flexible mode doesn't work in browsers that haven't implemented [the new absolute position behavior inside a flex container](https://developers.google.com/web/updates/2016/06/absolute-positioned-children) (e.g. iOS Safari), which means that the position will be thrown off completely. These changes rework the position strategy to use `position: static` and `justify-content`/`align-items`, rather than `position: absolute`, to push the overlay pane to the proper edge of the bounding box in flexible mode. As a result, support for having flexible dimensions in only one direction has been removed.
crisbeto
force-pushed
the
flexible-positioning-flexbox-fix
branch
from
e8583d1 to
97b7446
Compare
crisbeto
changed the title
crisbeto
added
pr: needs review
and removed
in progress
crisbeto
added
the
P1
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently using centering with the
FlexibleConnectedPositionStrategyin flexible mode doesn't work in browsers that haven't implemented the new absolute position behavior inside a flex container (e.g. iOS Safari), which means that the position will be thrown off completely. These changes rework the position strategy to useposition: staticandjustify-content/align-items, rather thanposition: absolute, to push the overlay pane to the proper edge of the bounding box in flexible mode. As a result, support for having flexible dimensions in only one direction has been removed.