fix(button): apply color classes correctly. #195
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
src/components/button/button.ts
Outdated
|
|
||
| _updateColor(newColor: string) { | ||
| if (this._color != null && this._color != '') { | ||
| this.renderer.setElementClass(this.elementRef.nativeElement, `md-${newColor}`, false); |
There was a problem hiding this comment.
Should be this._color in the template expression
There was a problem hiding this comment.
Indeed - fixed it, thanks!
devversion
force-pushed
the
fix/button-color-theme
branch
from
0659ebe to
2f337d1
Compare
|
|
||
| if (newColor != null && newColor != '') { | ||
| this.renderer.setElementClass(this.elementRef.nativeElement, `md-${newColor}`, true); | ||
| } |
There was a problem hiding this comment.
There's a bit of repetition between lines 61-63 and lines 65-67. Can you refactor to share more code, like:
_updateColor(newColor: string): void {
this._setElementColor(this._color, false);
this._setElementColor(newColor, true);
this._color = newColor;
}
_setElementColor(color: string, bool: boolean): void {
if (color != null && color != '') {
this.renderer.setElementClass(this.elementRef.nativeElement, `md-${color}`, bool);
}
}There was a problem hiding this comment.
@kara Changed it as discussed. Thanks for the suggestion.
devversion
force-pushed
the
fix/button-color-theme
branch
from
2f337d1 to
1b8b156
Compare
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75. Closes #89