feat(button): add md-icon-button styling. #206
Conversation
googlebot
added
the
cla: yes
src/components/button/button.scss
Outdated
| height: 40px; | ||
|
|
||
| line-height: 24px; | ||
| border-radius: 50%; |
There was a problem hiding this comment.
I see that the material1 icon-button is the same, but I'm curious: why does it use border-radius: 50%?
There was a problem hiding this comment.
Because if you have a 24x24 square, then 50% of all sides will be used to archive a responsive perfect circle.
So it's needed to make the element round, like in polymer-icon-button and Material 1
|
cc @kara |
src/components/button/button.scss
Outdated
| min-width: 0; | ||
| padding: 0; | ||
|
|
||
| width: 40px; |
There was a problem hiding this comment.
Would you mind putting this in a Sass variable? All other button sizes are variables in _button_base.scss, so dense layouts can adjust as necessary.
devversion
force-pushed
the
feat/md-icon-button
branch
2 times, most recently
from
2a23a6e to
e4ea5e9
Compare
* Added md-icon-button component * Showcased the md-icon-button in the button demos. Fixes angular#188
devversion
force-pushed
the
feat/md-icon-button
branch
from
e4ea5e9 to
a7cbd16
Compare
|
LGTM |
|
I wonder why this isn't included in the documentation examples :( |
|
@willshowell awesome! thanks |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I noticed that the icon-button is like a clone of a min-fab, maybe we can make the fab mixin more generic, to let it use by the icon-button too.
Fixes #188