Skip to content

Conversation

@atrawally
Copy link
Contributor

fix(docs/typography-guide): Defining a level

Fixes a bug in the Topography Guide where a function was incorrectly named. Replaces 'define-topography-config' with 'define-topography-level'

Fixes #25030

@atrawally atrawally requested a review from jelbourn as a code owner June 13, 2022 13:18
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Jun 13, 2022
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Jun 15, 2022
@crisbeto
Copy link
Member

Changing the target to minor since there's a conflict with the patch branch.

@crisbeto crisbeto merged commit 2fc61f4 into angular:main Jun 15, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: minor This PR is targeted for the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs-bug(Typography): Defining a Level

3 participants