Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 7, 2022

Fixes an issue where the content of a stepper that is nested inside of a <mat-tab-group> becomes invisible after the first navigation. This appears to be some sort of a bug where the visibility: inherit that we have on the stepper doesn't get recalculated so it stays hidden.

Fixes #25925.

…nested in tabs

Fixes an issue where the content of a stepper that is nested inside of a `<mat-tab-group>` becomes invisible after the first navigation. This appears to be some sort of a bug where the `visibility: inherit` that we have on the stepper doesn't get recalculated so it stays `hidden`.

Fixes angular#25925.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 7, 2022
@crisbeto crisbeto requested a review from mmalerba as a code owner November 7, 2022 08:32
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 7, 2022
@crisbeto crisbeto self-assigned this Nov 7, 2022
@crisbeto crisbeto merged commit 7e3a9df into angular:main Nov 7, 2022
crisbeto added a commit that referenced this pull request Nov 7, 2022
…nested in tabs (#25930)

Fixes an issue where the content of a stepper that is nested inside of a `<mat-tab-group>` becomes invisible after the first navigation. This appears to be some sort of a bug where the `visibility: inherit` that we have on the stepper doesn't get recalculated so it stays `hidden`.

Fixes #25925.

(cherry picked from commit 7e3a9df)
crisbeto added a commit that referenced this pull request Nov 7, 2022
…nested in tabs (#25930)

Fixes an issue where the content of a stepper that is nested inside of a `<mat-tab-group>` becomes invisible after the first navigation. This appears to be some sort of a bug where the `visibility: inherit` that we have on the stepper doesn't get recalculated so it stays `hidden`.

Fixes #25925.

(cherry picked from commit 7e3a9df)
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Nov 11, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.6` -> `14.2.7`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.6/14.2.7) |
| [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.6` -> `14.2.7`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.6/14.2.7) |

---

### Release Notes

<details>
<summary>angular/components</summary>

### [`v14.2.7`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#&#8203;1427-smoke-spirit-2022-11-09)

[Compare Source](angular/components@14.2.6...14.2.7)

##### cdk

| Commit | Type | Description |
| -- | -- | -- |
| [f63918a3b8](angular/components@f63918a) | fix | **scrolling:** error when querying for CdkVirtualScrollViewport as CdkScrollable ([#&#8203;25937](angular/components#25937)) |

##### material

| Commit | Type | Description |
| -- | -- | -- |
| [53588b51d2](angular/components@53588b5) | fix | **stepper:** add HCM disabled styles for stepper and tabs ([#&#8203;25393](angular/components#25393)) ([#&#8203;25932](angular/components#25932)) |
| [a1473b93fc](angular/components@a1473b9) | fix | **stepper:** content not visibile on first navigation when nested in tabs ([#&#8203;25930](angular/components#25930)) |

#### Special Thanks

Douglas Parker, Kristiyan Kostadinov and Wagner Maciel

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yMS4yIiwidXBkYXRlZEluVmVyIjoiMzQuMjIuMSJ9-->

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1635
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(COMPONENT): Use a stepper inside a tab
2 participants