Skip to content

fix(cdk-experimental/listbox): use meta as alternative to ctrl #30852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

fix(cdk-experimental/listbox): use meta as alternative to ctrl #30852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/cdk-experimental/ui-patterns/listbox/listbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,13 @@ export class ListboxPattern<V> {
.on(Modifier.Shift, 'Enter', () => this._updateSelection({selectFromAnchor: true}))
.on(Modifier.Shift, this.prevKey, () => this.prev({toggle: true}))
.on(Modifier.Shift, this.nextKey, () => this.next({toggle: true}))
.on(Modifier.Ctrl | Modifier.Shift, 'Home', () => this.first({selectFromActive: true}))
.on(Modifier.Ctrl | Modifier.Shift, 'End', () => this.last({selectFromActive: true}))
.on(Modifier.Ctrl, 'A', () => this._updateSelection({selectAll: true}))
.on([Modifier.Ctrl, Modifier.Meta], 'A', () => this._updateSelection({selectAll: true}))
.on([Modifier.Ctrl | Modifier.Shift, Modifier.Meta | Modifier.Shift], 'Home', () =>
this.first({selectFromActive: true}),
)
.on([Modifier.Ctrl | Modifier.Shift, Modifier.Meta | Modifier.Shift], 'End', () =>
this.last({selectFromActive: true}),
)
.on(Modifier.Shift, this.dynamicSpaceKey, () =>
this._updateSelection({selectFromAnchor: true}),
);
Expand All @@ -153,12 +157,12 @@ export class ListboxPattern<V> {

if (this.inputs.multi() && this.followFocus()) {
manager
.on(Modifier.Ctrl, this.prevKey, () => this.prev())
.on(Modifier.Ctrl, this.nextKey, () => this.next())
.on(Modifier.Ctrl, ' ', () => this._updateSelection({toggle: true}))
.on(Modifier.Ctrl, 'Enter', () => this._updateSelection({toggle: true}))
.on(Modifier.Ctrl, 'Home', () => this.first()) // TODO: Not in spec but prob should be.
.on(Modifier.Ctrl, 'End', () => this.last()); // TODO: Not in spec but prob should be.
.on([Modifier.Ctrl, Modifier.Meta], this.prevKey, () => this.prev())
.on([Modifier.Ctrl, Modifier.Meta], this.nextKey, () => this.next())
.on([Modifier.Ctrl, Modifier.Meta], ' ', () => this._updateSelection({toggle: true}))
.on([Modifier.Ctrl, Modifier.Meta], 'Enter', () => this._updateSelection({toggle: true}))
.on([Modifier.Ctrl, Modifier.Meta], 'Home', () => this.first()) // TODO: Not in spec but prob should be.
.on([Modifier.Ctrl, Modifier.Meta], 'End', () => this.last()); // TODO: Not in spec but prob should be.
}

return manager;
Expand Down
Loading