fix(material/button): FAB emitting invalid elevation tokens #31028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FAB was re-defining its elevation tokens for each variant, however the logic that converts elevation values from numbers to shadows was running only on the top-level tokens. At runtime this leads to no shadow being shown, because we were emitting a number. These changes remove the elevation overrides for the variants, because they're the same as the base.
crisbeto
requested review from
adolgachev and
mmalerba
and removed request for
a team
andrewseguin
approved these changes
May 5, 2025
crisbeto
added
action: merge
wildcardalice
pushed a commit
to wildcardalice/components
that referenced
this pull request
May 12, 2025
…31028) The FAB was re-defining its elevation tokens for each variant, however the logic that converts elevation values from numbers to shadows was running only on the top-level tokens. At runtime this leads to no shadow being shown, because we were emitting a number. These changes remove the elevation overrides for the variants, because they're the same as the base.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FAB was re-defining its elevation tokens for each variant, however the logic that converts elevation values from numbers to shadows was running only on the top-level tokens. At runtime this leads to no shadow being shown, because we were emitting a number.
These changes remove the elevation overrides for the variants, because they're the same as the base.