fix(material/stepper): Adjust aria tab-related roles to fix violations #31844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adolgachev
force-pushed
the
stepper-tweak
branch
from
eb187f4 to
b984662
Compare
adolgachev
added
target: minor
|
Deployed dev-app for e319459 to: https://ng-dev-previews-comp--pr-angular-components-31844-dev-p3vqpt53.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
force-pushed
the
stepper-tweak
branch
from
3dde1a5 to
42da30d
Compare
adolgachev
requested review from
crisbeto and
ok7sai
and removed request for
a team
adolgachev
removed
the
action: global presubmit
ok7sai
approved these changes
Sep 15, 2025
adolgachev
requested review from
wagnermaciel
and removed request for
crisbeto
adolgachev
force-pushed
the
stepper-tweak
branch
from
66b8e53 to
e319459
Compare
adolgachev
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes b/361783174 by addressing the incorrect placement of tabpanel roles inside the tab list.
For horizontal, can move the tablist down to the div which only wraps the actual tabs.
For vertical, it is triickier as the tab content is placed inline with the tab headers. For that, had to change to no longer use the tab roles.