Skip to content

Conversation

PowerKiKi
Copy link
Contributor

This is consistent with checkbox behavior.

Radio used to work that way too until Angular Material v14. v15 broke it, and it remained broken until now.

Fixes #26067, at least partially

image

@PowerKiKi PowerKiKi requested a review from a team as a code owner September 18, 2025 09:33
@PowerKiKi PowerKiKi requested review from adolgachev and wagnermaciel and removed request for a team September 18, 2025 09:34
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: material/radio labels Sep 18, 2025
@include radio-common.radio-structure(true);
@include radio-common.radio-noop-animations();

// Clicking the label toggles the checkbox, but MDC does not include any styles that inform the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...toggles the radio button..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in amended commit

…inter cursor

This is consistent with checkbox behavior.

Radio used to work that way too until Angular Material v14. v15
broke it, and it remained broken until now.

Fixes angular#26067, at least partially
@PowerKiKi PowerKiKi force-pushed the hover-on-radio-labels branch from bf08518 to 16fdad3 Compare September 22, 2025 04:29
@adolgachev adolgachev removed the request for review from wagnermaciel September 24, 2025 03:04
@adolgachev adolgachev added dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase action: merge The PR is ready for merge by the caretaker labels Sep 24, 2025
Copy link

Deployed dev-app for 16fdad3 to: https://ng-dev-previews-comp--pr-angular-components-31894-dev-phoxz4v7.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link

Deployed docs-preview for 16fdad3 to: https://ng-dev-previews-comp--pr-angular-components-31894-docs-4ouhfuk7.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@adolgachev adolgachev added target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Sep 24, 2025
@adolgachev adolgachev merged commit 737c69f into angular:main Sep 24, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: material/radio detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(checkbox, radio, toggle): inhomogenous ripple effects and other styles
3 participants