Skip to content

fix(select): icons inside option not centered #9982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2018
Merged

fix(select): icons inside option not centered #9982

merged 1 commit into from
Feb 18, 2018

Conversation

crisbeto
Copy link
Member

Fixes mat-icon instances inside a mat-option not being centered vertically.

Fixes #9978.

@crisbeto
fix(select): icons inside option not centered
983951c 
Fixes `mat-icon` instances inside a `mat-option` not being centered vertically.

Fixes angular#9978.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 16, 2018
jelbourn
jelbourn approved these changes Feb 17, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 17, 2018
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Feb 17, 2018
@jelbourn jelbourn merged commit 9914312 into angular:master Feb 18, 2018
tinayuangao pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @tinayuangao
fix(select): icons inside option not centered (#9982)
7c123b8 
Fixes `mat-icon` instances inside a `mat-option` not being centered vertically.

Fixes #9978.
andrewseguin pushed a commit that referenced this pull request Feb 20, 2018
@crisbeto @andrewseguin
fix(select): icons inside option not centered (#9982)
ecc7f53 
Fixes `mat-icon` instances inside a `mat-option` not being centered vertically.

Fixes #9978.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@kara kara Awaiting requested review from kara

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Icons are not vertically aligned inside mat-option elements
3 participants
@crisbeto @jelbourn @googlebot