Conversation
|
This is impressive work llama! I'll need a bit more time to review the current code properly, but I wanted to give you some quick feedback to unblock you.
thread 'tokio-runtime-worker' panicked at qt/launcher-gui/src-tauri/src/commands.rs:140:58: The existing code expects the launcher binary to be run from within an app bundle. This is how the layout looks like for the terminal version: build.sh in qt/launcher/mac takes care of the building that folder after compiling. If you don't have access to a Mac, I can take care of this before the alpha test. Should hopefully have more comments in the next few days! |
to make alert() work
xterm.js' new DOM renderer seems to have some visual glitches, try using the webgl renderer first before falling back
this broke somewhere down the line and needs a tick now
|
I probably won't have a chance to circle back to this until late this week/early next week :-( If you're blocked on anything, please let me know and I'll try to get to that earlier. |
c24a17d to
1622f9b
Compare
|
Just wanted to give you a bit of an update/some background. The decision to go with a launcher approach was partly due to feeling overwhelmed, and wanting to reduce the overhead of making releases. I figured it'd get users something close to auto-update support at the same time, so it seemed like a win-win. But between uv edge cases and users' eyes glazing over the moment a terminal window appears, it hasn't been as smooth as I'd hoped. A launcher GUI is the logical next step. It should solve a bunch of pain points/be more user-friendly. But it doesn't solve all problems (e.g. #4151), and some users want to be able to do a single download without subsequent extra downloads. Months back Andrew floated the idea of using Briefcase instead, which is closer to our old PyOxidizer setup. We have extra hands at our disposal now, making maintenance less of a concern, so that may be more practical now. I think we might want to explore that path in more detail (only a very basic PoC so far), and then decide whether to persist down the launcher path, provide both in parallel, use some hybrid approach, or switch over to a more conventional packaged build. |
To run, install tauri's system dependencies, cli (cargo) and then, in the repo root,
cargo tauri devwith.\yarn ldin another windowTentatively based it on the options pages (i probably won't be of much help here)
Closes #4152
EDIT: CI is missing some of tauri's needed system deps