Skip to content

Conversation

ekkinox
Copy link
Contributor

@ekkinox ekkinox commented May 10, 2024

FxSQL module :

  • sql.DB built from config and Fx injection
  • hooks
  • migrator
  • seeder

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 98.13665% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 98.98%. Comparing base (85073b5) to head (5f68eb3).

Files Patch % Lines
fxsql/module.go 96.10% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   95.96%   98.98%   +3.02%     
==========================================
  Files         171        9     -162     
  Lines        6099      297    -5802     
==========================================
- Hits         5853      294    -5559     
+ Misses        174        2     -172     
+ Partials       72        1      -71     
Flag Coverage Δ
config ?
fxconfig ?
fxcore ?
fxcron ?
fxgenerate ?
fxgrpcserver ?
fxhealthcheck ?
fxhttpclient ?
fxhttpserver ?
fxlog ?
fxmetrics ?
fxorm ?
fxsql 98.98% <98.13%> (?)
fxtrace ?
fxworker ?
generate ?
grpcserver ?
healthcheck ?
httpclient ?
httpserver ?
log ?
orm ?
sql ?
trace ?
worker ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ndk ndk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekkinox ekkinox marked this pull request as ready for review May 10, 2024 14:42
@ndk ndk self-requested a review May 10, 2024 14:52
Copy link
Contributor

@Skyld Skyld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few very minor comments, excellent work 🙌

@ekkinox ekkinox merged commit d497caa into main May 13, 2024
@ekkinox ekkinox deleted the feat/fxsql branch May 13, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants