Skip to content

WDC Redfish support for chassis indicator LED toggling.#5059

Merged
felixfontein merged 3 commits intoansible-collections:mainfrom
mikemoerk:wdc_redfish_chassis_led
Aug 7, 2022
Merged

WDC Redfish support for chassis indicator LED toggling.#5059
felixfontein merged 3 commits intoansible-collections:mainfrom
mikemoerk:wdc_redfish_chassis_led

Conversation

@mikemoerk
Copy link
Contributor

@mikemoerk mikemoerk commented Aug 2, 2022

SUMMARY

WDC Enclosure support for indicator LED toggling for various chassis components, including:

  • Enclosure
  • I/O Modules
  • Power Supplies
  • External Fans
  • Internal Fan
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

wdc_redfish_command

ADDITIONAL INFORMATION

Sample command:

ansible mm4 -m community.general.wdc_redfish_command -a "username={{ user }} password={{ pass }} baseuri={{ioms[0]}} category=Chassis resource_id=FanInternalFRU command=IndicatorLedOn"

@ansibullbot
Copy link
Collaborator

ansibullbot commented Aug 2, 2022

cc @Bhavya06 @mraineri @rajeevkallur @renxulei @tomasg2012 @xmadsen
click here for bot help

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module module_utils module_utils plugins plugin (any type) remote_management tests tests unit tests/unit labels Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Aug 2, 2022 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 labels Aug 3, 2022
felixfontein
felixfontein reviewed Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

mikemoerk and others added 2 commits August 3, 2022 15:36
@mikemoerk
Added changelog fragment.
ff83a63
@mikemoerk @felixfontein
Apply suggestions from code review
d4bf896 
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
felixfontein approved these changes Aug 5, 2022
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (without looking too closely at the code, I assume you did enough testing on this).

@mraineri
Copy link
Contributor

mraineri commented Aug 5, 2022

shipit

russoz
russoz approved these changes Aug 7, 2022
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also assuming thorough tests have been executed

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 7, 2022
@felixfontein felixfontein merged commit 6062ae8 into ansible-collections:main Aug 7, 2022
@patchback
Copy link

patchback bot commented Aug 7, 2022 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/6062ae8fae89c58392e985178fbf65f9fefb7b49/pr-5059

Backported as #5086

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Aug 7, 2022
@mikemoerk @felixfontein @patchback
WDC Redfish support for chassis indicator LED toggling. (#5059)
3a9a9e5 
* WDC Redfish support for chassis indicator LED toggling.

* Added changelog fragment.

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 6062ae8)
@patchback patchback bot mentioned this pull request Aug 7, 2022
Merged
@felixfontein
Copy link
Collaborator

felixfontein commented Aug 7, 2022

@mikemoerk thanks for implementing this!
@mraineri @russoz thanks for reviewing this!

felixfontein pushed a commit that referenced this pull request Aug 7, 2022
@patchback @mikemoerk
WDC Redfish support for chassis indicator LED toggling. (#5059) (#5086)
df59034 
* WDC Redfish support for chassis indicator LED toggling.

* Added changelog fragment.

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 6062ae8)

Co-authored-by: Mike Moerk <mike@moerk.org>
aidanbh pushed a commit to aidanbh/ansible-collections-community.general that referenced this pull request Aug 8, 2022
@mikemoerk @felixfontein @aidanbh
WDC Redfish support for chassis indicator LED toggling. (ansible-coll…
33d7336 
…ections#5059)

* WDC Redfish support for chassis indicator LED toggling.

* Added changelog fragment.

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@mikemoerk @felixfontein
WDC Redfish support for chassis indicator LED toggling. (ansible-coll…
7845ffc 
…ections#5059)

* WDC Redfish support for chassis indicator LED toggling.

* Added changelog fragment.

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@mikemoerk @felixfontein
WDC Redfish support for chassis indicator LED toggling. (ansible-coll…
ba4c3e5 
…ections#5059)

* WDC Redfish support for chassis indicator LED toggling.

* Added changelog fragment.

* Apply suggestions from code review

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
@trux-bot trux-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@anaconda-renovate-bot anaconda-renovate-bot mentioned this pull request Nov 14, 2022
Merged
1 task
This was referenced Nov 15, 2022
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russoz russoz russoz approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees

No one assigned

Labels

feature This issue/PR relates to a feature request module_utils module_utils module module plugins plugin (any type) remote_management shipit tests tests unit tests/unit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mikemoerk @ansibullbot @mraineri @felixfontein @russoz