Skip to content

Conversation

@GomathiselviS
Copy link
Contributor

SUMMARY

This PR pins ansible-lint version to 6.21.x and organizes the workflows based on https://github.com/ansible-collections/cloud-content-handbook/blob/main/CI/README.md.

Refer https://issues.redhat.com/browse/ACA-1117

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link

@GomathiselviS GomathiselviS changed the title Cleanup GitHub workflows WIP: Cleanup GitHub workflows Nov 6, 2023
@GomathiselviS GomathiselviS marked this pull request as draft November 6, 2023 17:25
@softwarefactory-project-zuul
Copy link

@softwarefactory-project-zuul
Copy link

@softwarefactory-project-zuul
Copy link

@GomathiselviS GomathiselviS requested a review from gravesm November 6, 2023 21:24
@GomathiselviS GomathiselviS changed the title WIP: Cleanup GitHub workflows Cleanup GitHub workflows Nov 6, 2023
@GomathiselviS GomathiselviS marked this pull request as ready for review November 6, 2023 21:24
@softwarefactory-project-zuul
Copy link

@softwarefactory-project-zuul
Copy link

@softwarefactory-project-zuul
Copy link

@softwarefactory-project-zuul
Copy link

Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not use the flyint for the linters ?

yamllint
commands =
{[testenv:black_check]commands}
black -v --check {toxinidir}/plugins {toxinidir}/tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
black -v --check {toxinidir}/plugins {toxinidir}/tests
flynt {[common]format_dirs}
black -v --check {toxinidir}/plugins {toxinidir}/tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use flynt we should add it to the linters in https://github.com/ansible-collections/cloud-content-handbook/tree/main/CI. For this PR, we should merge this as is. We can look at adding flynt later.

[testenv:linters]
deps =
yamllint
{[testenv:black]deps}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{[testenv:black]deps}
{[testenv:black]flynt}
{[testenv:black]deps}

@softwarefactory-project-zuul
Copy link

@abikouo abikouo added test-all-the-targets In order to tell to the integration test splitter to test all targets and removed mergeit labels Nov 10, 2023
@abikouo
Copy link
Contributor

abikouo commented Nov 10, 2023

@gravesm removing the mergeit and adding test-all-the-targets label to see if the full integration tests suite is passing.
if ok, I will add it back.

@softwarefactory-project-zuul
Copy link

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/9720432c677848a3928457c87d365809

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 7m 31s

@softwarefactory-project-zuul
Copy link

Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry.

@abikouo abikouo merged commit b066a2d into ansible-collections:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit test-all-the-targets In order to tell to the integration test splitter to test all targets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants