-
Notifications
You must be signed in to change notification settings - Fork 157
Cleanup GitHub workflows #655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 12m 53s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 34s |
|
Build failed. ❌ ansible-galaxy-importer POST_FAILURE in 18m 43s |
|
Build failed. ❌ ansible-galaxy-importer POST_FAILURE in 9m 51s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 19s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 13m 00s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 12m 29s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 13m 22s |
abikouo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not use the flyint for the linters ?
| yamllint | ||
| commands = | ||
| {[testenv:black_check]commands} | ||
| black -v --check {toxinidir}/plugins {toxinidir}/tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| black -v --check {toxinidir}/plugins {toxinidir}/tests | |
| flynt {[common]format_dirs} | |
| black -v --check {toxinidir}/plugins {toxinidir}/tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to use flynt we should add it to the linters in https://github.com/ansible-collections/cloud-content-handbook/tree/main/CI. For this PR, we should merge this as is. We can look at adding flynt later.
| [testenv:linters] | ||
| deps = | ||
| yamllint | ||
| {[testenv:black]deps} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| {[testenv:black]deps} | |
| {[testenv:black]flynt} | |
| {[testenv:black]deps} |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 15s |
|
@gravesm removing the |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 06s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 41s |
|
Pull request merge failed: Resource not accessible by integration, You may need to manually rebase your PR and retry. |
SUMMARY
This PR pins ansible-lint version to 6.21.x and organizes the workflows based on https://github.com/ansible-collections/cloud-content-handbook/blob/main/CI/README.md.
Refer https://issues.redhat.com/browse/ACA-1117
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION