Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/898-k8s-dont-delete-in-check-mode.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
bugfixes:
- module_utils/k8s/service - fix issue when trying to delete resource using `delete_options` and `check_mode=true` (https://github.com/ansible-collections/kubernetes.core/issues/892).
2 changes: 1 addition & 1 deletion plugins/module_utils/k8s/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ def delete(
if label_selectors:
params["label_selector"] = ",".join(label_selectors)

if delete_options:
if delete_options and not self.module.check_mode:
body = {
"apiVersion": "v1",
"kind": "DeleteOptions",
Expand Down
21 changes: 21 additions & 0 deletions tests/integration/targets/k8s_delete/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,27 @@
register: _deployment
failed_when: _deployment.resources | length == 0

- name: Trying to delete nginx deployment in check mode and with deleteOptions set
k8s:
kind: Deployment
api_version: apps/v1
namespace: "{{ test_namespace }}"
name: nginx-d
state: absent
delete_options:
propagationPolicy: Foreground
check_mode: true
register: _delete

- name: Validate that Deployment nginx-d still exists
k8s_info:
kind: Deployment
api_version: apps/v1
namespace: "{{ test_namespace }}"
name: nginx-d
register: _deployment
failed_when: _deployment.resources | length != 1

- name: Trying to delete using delete_all=true but missing kind option
k8s:
api_version: apps/v1
Expand Down
Loading