[PR #802/00699ac3 backport][stable-3] add reset_then_reuse_values support to helm module #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUMMARY Starting with version 3.14.0, Helm supports --reset-then-reuse-values. As discussed on the original PR. This greatly improves on --reuse-values as it allows to avoid templates errors when new features are added to an upgraded chart. Closes #803 ISSUE TYPE Feature Pull Request COMPONENT NAME helm ADDITIONAL INFORMATION This PR is greatly 'inspired' by #575 and because I wasn't sure how I could provide additional tests for it, I actually copied those build previously for --reuse-values (as it is an improvement on this feature. Reviewed-by: Bikouo Aubin Reviewed-by: Yuriy Novostavskiy Reviewed-by: b0z02003 Reviewed-by: Bianca Henderson <[email protected]> (cherry picked from commit 00699ac)
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 21s |
Contributor
|
Probably we should backport that chnage to Idea that new features will go to 5.x.y and 6.x.y, and only bugfixes to 3.x.y. Let it discuss separately. |
Contributor
That makes sense, @yurnov . I am going to go ahead and close this backport PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #802 as merged into main (00699ac).
SUMMARY
Starting with version 3.14.0, Helm supports
--reset-then-reuse-values. As discussed on the original PR. This greatly improves on--reuse-valuesas it allows to avoid templates errors when new features are added to an upgraded chart.Closes #803
ISSUE TYPE
COMPONENT NAME
helm
ADDITIONAL INFORMATION
This PR is greatly 'inspired' by #575 and because I wasn't sure how I could provide additional tests for it, I actually copied those build previously for
--reuse-values(as it is an improvement on this feature.