cloud integration tests jobs: test splitter, integration tests runner #45
Conversation
abikouo
force-pushed
the
cloud_splitter
branch
from
ed26976 to
72b0675
Compare
abikouo
force-pushed
the
cloud_splitter
branch
from
bf153ae to
13b3a0e
Compare
| @@ -0,0 +1,50 @@ | |||
| name: Retrieve collection information | |||
There was a problem hiding this comment.
Why not make this a resuable workflow? It seems like it would save a bunch of boilerplate having to be created in each repo using this.
There was a problem hiding this comment.
Looking at this further, I think my issue is less with this being a composite action and more with how it is being used by the other repos. I'll put my comments in those.
abikouo
changed the title
There was a problem hiding this comment.
What exactly is this doing for this PR? There's no scripts folder attached to this PR, and no tests on the PR that has one.
|
I realize it might be a little work, but would you mind breaking this PR up into smaller PRs? It's a little difficult to grok it all at once. Also- I think this might need a look, I'm not sure we want to call into a personal repo: abikouo/github_actions/.github/actions/build_install_collection@cloud_splitter |
|
I'm assuming that's there for testing the workflow, but yeah that needs to get fixed before this can be considered. Do you have a PR this is running on? |
|
Split into multiple PR |
4 participants
This pull request contains a set of features to run cloud integration tests
ansible_test_integrationaction aims to run integration tests for a set of targets usingansible-testcommandbuild_install_collectionhas been fixed for collection not definedversionin the galaxy.yml file, for theses collections we need to generate it before installing the collection