Make devel tests "optional" #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The version mangling can probably just be dropped at this point. The problem we were avoiding with this has been solved elsewhere. |
tremble
force-pushed
the
devel/optional
branch
2 times, most recently
from
0e2a262 to
e298d98
Compare
tremble
changed the title
Contributor
Author
|
@Qalthos Can we get this one reviewed/merged too please |
Qalthos
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The devel branch includes new tests and will break sanity tests with minimal notice. While these issues generally still need fixing they shouldn't block folks from continuing to work on unrelated features.
By using "continue-on-error" we can allow devel sanity test failures to be "optional". They'll still show up in the test results, however the 'status' of the workflow will count as successful.
Forcefully overwriting the galaxy version information means that until a release has been tagged the sanity tests won't pick up deprecation which should have been removed already. Since adding the tag actually performs the release this is way too late.(Moved to #48)