-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New module - s3_logging #680
Conversation
|
cc @ansible/aws |
cloud/amazon/s3_logging.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to http://docs.ansible.com/developing_modules.html#module-checklist, default is not needed when required is true.
|
@wimnat I did a some quick testing with this one and it works as advertised. Just a couple of documentation updates needed. The module is requiring target_bucket on absent so I think it should be added to the example. |
|
@RickMendes I've removed the target_bucket requirement and updated the doc to mention it is required for state=present. I didn't want to have state=absent dependent on target_bucket. |
|
@wimnat That works for me. It makes more sense to me to not have it required for state-absent. I give this a +1. |
cloud/amazon/s3_logging.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm guessing the default here is null or is 'no' the prefix that gets added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be an empty string rather than null.
New module to manage logging option of s3 buckets