Skip to content
This repository was archived by the owner on Oct 30, 2018. It is now read-only.

Conversation

@wimnat
Copy link
Contributor

@wimnat wimnat commented Jul 6, 2015

New module to manage logging option of s3 buckets

@gregdek
Copy link
Contributor

gregdek commented Jul 6, 2015

cc @ansible/aws

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to http://docs.ansible.com/developing_modules.html#module-checklist, default is not needed when required is true.

@ghost
Copy link

ghost commented Jul 17, 2015

@wimnat I did a some quick testing with this one and it works as advertised. Just a couple of documentation updates needed. The module is requiring target_bucket on absent so I think it should be added to the example.

@wimnat
Copy link
Contributor Author

wimnat commented Jul 19, 2015

@RickMendes I've removed the target_bucket requirement and updated the doc to mention it is required for state=present. I didn't want to have state=absent dependent on target_bucket.

@ghost
Copy link

ghost commented Jul 19, 2015

@wimnat That works for me. It makes more sense to me to not have it required for state-absent. I give this a +1.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm guessing the default here is null or is 'no' the prefix that gets added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be an empty string rather than null.

bcoca added a commit that referenced this pull request Jul 19, 2015
@bcoca bcoca merged commit 591c22b into ansible:devel Jul 19, 2015
@wimnat wimnat deleted the feature/s3_logging branch July 29, 2015 09:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants