-
Notifications
You must be signed in to change notification settings - Fork 58
fix: example deprecation warnings and improvements #4579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gobot1234
wants to merge
31
commits into
main
Choose a base branch
from
jhilton-/example-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+543
−350
Open
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
005b37a
Add type level support for passing Path instances to download_file
Gobot1234 a41b780
Pre-emptively fix isort
Gobot1234 e06bbbd
Fix black
Gobot1234 79beceb
fix: solver session settings access in tests and examples
Gobot1234 a9d95d3
revert: some of the broken updates
Gobot1234 c3fc60e
chore: add acronym for DOE
Gobot1234 376508f
Move the boundary layer update
Gobot1234 0063e0c
Apply suggestion from @Gobot1234
Gobot1234 a6c1804
Fix some review issues
Gobot1234 0aa7841
Merge branch 'main' into example-updates
Gobot1234 9e02c58
Fix typo
Gobot1234 5f9fd49
fix: old syntax for camera position
Gobot1234 e101c51
refactor: make the code more pythonic
Gobot1234 313b069
Merge branch 'main' into example-updates
Gobot1234 2343b7a
fix ci
Gobot1234 c8a59db
chore: adding changelog file 4579.fixed.md [dependabot-skip]
pyansys-ci-bot ebc90ce
Adda couple of missed deprecations
Gobot1234 af2156f
Merge branch 'main' into jhilton-/example-updates
Gobot1234 5b0326f
fmt
Gobot1234 701650b
oops
Gobot1234 4f8fa85
fix tui change
Gobot1234 a3fcc89
rm the unnecessary space
Gobot1234 60f3292
Improve session guide
Gobot1234 f632441
fix ci potentially
Gobot1234 387ce45
Apply more of Sean's comments
Gobot1234 ab758a2
fix ci more
Gobot1234 22e7f71
penultimate round of fixes before bed
Gobot1234 a93ae3c
fmt again :)
Gobot1234 a6e3199
revert changes to tests
Gobot1234 8ea0f85
Merge main branch to resolve test file conflicts
Gobot1234 673a5f2
Revert all test file changes to match main
Gobot1234 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
revert: some of the broken updates
- Loading branch information
commit a9d95d33d1294a6915d17fe9fe40c69b95399c78
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # "matplotlib", | ||
| # "numpy", | ||
| # "pandas", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # "matplotlib", | ||
| # "numpy", | ||
| # "pandas", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # "ansys-fluent-visualization", | ||
| # ] | ||
| # /// | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # /// script | ||
| # dependencies = [ | ||
| # "imageio", | ||
| # "pyfluent", | ||
| # "ansys-fluent-core", | ||
| # ] | ||
| # /// | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The assertion checks for the deprecated access pattern
<solver_session>.file.read_caseinstead of the updated pattern<solver_session>.settings.file.read_case. This contradicts the PR's goal of updating to the new API.