feat: Update client side 'enhanced' meshing workflow to use server side 'meshing_workflow' root. #4600
Conversation
…de 'meshing_workflow' root.
…_meshing_workflow
…rkflow' of https://github.com/ansys/pyfluent into feat/update_enhanced_meshing_workflow_to_use_meshing_workflow
…_meshing_workflow
…_meshing_workflow
There was a problem hiding this comment.
Pull request overview
This PR updates the client-side enhanced meshing workflow to utilize the server-side meshing_workflow root introduced in Fluent 26R1, controlled via the USE_SERVER_MW environment variable. The changes include a new workflow_new.py module that wraps server-side functionality, conditional logic to switch between old and new workflow implementations, and comprehensive test coverage for the enhanced workflow features including task insertion, deletion, renaming, and traversal mechanisms.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_server_meshing_workflow.py | Added comprehensive tests for enhanced meshing workflow features including task management, traversal, and three complete workflow implementations (watertight, fault-tolerant, 2D) |
| tests/conftest.py | Added use_server_meshing_workflow fixture to enable server-side workflow testing via environment variable |
| src/ansys/fluent/core/workflow_new.py | New module providing high-level Pythonic workflow interface with Workflow and TaskObject classes for task management and navigation |
| src/ansys/fluent/core/session_base_meshing.py | Updated workflow initialization methods to conditionally use meshing_workflow root based on environment variable |
| src/ansys/fluent/core/meshing/meshing_workflow.py | Modified to dynamically resolve workflow base class and conditionally execute initialization logic based on environment variable |
| doc/changelog.d/4600.added.md | Added changelog entry documenting the update |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seanpearsonuk
left a comment
seanpearsonuk
left a comment
There was a problem hiding this comment.
Approving based on conversations with @prmukherj
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prmukherj
deleted the
feat/update_enhanced_meshing_workflow_to_use_meshing_workflow
branch
4 participants
Context
Update the client side enhanced meshing workflow with respect to the server side updates in Fluent 26R1.
Change Summary
Simple wrappers to expose server side features with some additional improvement like the insertion and traversal mechanisms.
Impact
The users to experience an enhanced workflow experience.
Please refer tests for updated usages.
TODO: The user facing docs needs updates after Fluent 26R1 is released.